Add tests

Author: dvlpp

src/Filters/GlobalFilters/GlobalFilters.php

@@ -12,6 +12,7 @@ final class GlobalFilters implements Arrayable
     use HasFilters;
 
     public static string $defaultKey = 'root';
+    public static string $valuesUrlSeparator = '~';
 
     public function getFilters(): array
     {

src/Http/Context/SharpContext.php

@@ -32,7 +32,7 @@ public function globalFilterUrlSegmentValue(): string
             )
             ->map(fn (GlobalRequiredFilter $globalFilter) => $globalFilter->currentValue())
             ->filter()
-            ->implode(':') ?: GlobalFilters::$defaultKey;
+            ->implode(GlobalFilters::$valuesUrlSeparator) ?: GlobalFilters::$defaultKey;
     }
 
     public function retainedFilterValue(string $handlerClassOrKey): array|string|null

src/Http/Middleware/HandleGlobalFilters.php

@@ -3,6 +3,7 @@
 namespace Code16\Sharp\Http\Middleware;
 
 use Closure;
+use Code16\Sharp\Filters\GlobalFilters\GlobalFilters;
 use Code16\Sharp\Filters\GlobalRequiredFilter;
 use Illuminate\Http\Request;
 use Illuminate\Support\Facades\URL;
@@ -14,7 +15,7 @@ public function handle(Request $request, Closure $next)
         URL::defaults(['filterKey' => sharp()->context()->globalFilterUrlSegmentValue()]);
 
         if ($request->isMethod('GET') && ($filterKey = $request->route('filterKey'))) {
-            $filterKeys = explode(':', $filterKey);
+            $filterKeys = explode(GlobalFilters::$valuesUrlSeparator, $filterKey);
             $configuredGlobalFilters = collect(sharp()->config()->get('global_filters'))
                 ->map(fn ($globalFilterClassOrInstance) => is_string($globalFilterClassOrInstance)
                     ? app($globalFilterClassOrInstance)

tests/Http/GlobalFilterRoutesTest.php

@@ -65,16 +65,43 @@
     expect(sharp()->context()->globalFilterValue('test'))->toEqual('two');
 });
 
-// TODO test multiple filters
+it('redirects to route with correct filterKeys when missing and multiple global filters are defined', function () {
+    fakeGlobalFilter('test1');
+    fakeGlobalFilter('test2');
 
-function fakeGlobalFilter(): void
+    $this->get('/sharp/s-list/person')
+        ->assertRedirect('/sharp/two~two/s-list/person');
+
+    $this->post(route('code16.sharp.filters.update', 'test1'), ['value' => 'one']);
+    $this->post(route('code16.sharp.filters.update', 'test2'), ['value' => 'three']);
+
+    $this->get('/sharp/s-list/person/s-show/person/1')
+        ->assertRedirect('/sharp/one~three/s-list/person/s-show/person/1');
+});
+
+it('sets the current multiple filterKeys according to the URL', function () {
+    fakeGlobalFilter('test1');
+    fakeGlobalFilter('test2');
+
+    $this->post(route('code16.sharp.filters.update', 'test1'), ['value' => 'three']);
+    $this->post(route('code16.sharp.filters.update', 'test2'), ['value' => 'three']);
+    $this->get('/sharp/one~two/s-list/person/s-show/person/1')
+        ->assertOk();
+
+    expect(sharp()->context()->globalFilterValue('test1'))->toEqual('one');
+    expect(sharp()->context()->globalFilterValue('test2'))->toEqual('two');
+});
+
+function fakeGlobalFilter(string $key = 'test'): void
 {
     sharp()->config()->addGlobalFilter(
-        new class() extends GlobalRequiredFilter
+        new class($key) extends GlobalRequiredFilter
         {
+            public function __construct(private string $key) {}
+
             public function buildFilterConfig(): void
             {
-                $this->configureKey('test');
+                $this->configureKey($this->key);
             }
 
             public function values(): array