Skip to content

Commit 7468530

Browse files
committed
Followed most recommended changes.
1 parent 048d40a commit 7468530

3 files changed

Lines changed: 29 additions & 28 deletions

File tree

index.html

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -61,72 +61,72 @@
6161
<div class="wire"></div>
6262
<div class="front_clip"></div>
6363
<div class="back_clip"></div>
64-
<img class="slide-image" src="./assets/imgs/1.jpg" alt="BrickHack 6 attendees"/>
64+
<img src="./assets/imgs/1.jpg" class="slide-image" alt="BrickHack 6 attendees"/>
6565
</div>
6666
<div class="slide">
6767
<div class="wire"></div>
6868
<div class="front_clip"></div>
6969
<div class="back_clip"></div>
70-
<img class="slide-image" src="./assets/imgs/2.jpg" alt="BrickHack 6 attendees"/>
70+
<img src="./assets/imgs/2.jpg" class="slide-image" alt="BrickHack 6 attendees"/>
7171
</div>
7272
<div class="slide">
7373
<div class="wire"></div>
7474
<div class="front_clip"></div>
7575
<div class="back_clip"></div>
76-
<img class="slide-image" src="./assets/imgs/3.jpg" alt="BrickHack 6 attendees"/>
76+
<img src="./assets/imgs/3.jpg" class="slide-image" alt="BrickHack 6 attendees"/>
7777
</div>
7878
<div class="slide">
7979
<div class="wire"></div>
8080
<div class="front_clip"></div>
8181
<div class="back_clip"></div>
82-
<img class="slide-image" src="./assets/imgs/4.jpg" alt="BrickHack 6 attendees"/>
82+
<img src="./assets/imgs/4.jpg" class="slide-image" alt="BrickHack 6 attendees"/>
8383
</div>
8484
<div class="slide">
8585
<div class="wire"></div>
8686
<div class="front_clip"></div>
8787
<div class="back_clip"></div>
88-
<img class="slide-image" src="./assets/imgs/5.jpg" alt="BrickHack 6 attendees"/>
88+
<img src="./assets/imgs/5.jpg" class="slide-image" alt="BrickHack 6 attendees"/>
8989
</div>
9090
<div class="slide">
9191
<div class="wire"></div>
9292
<div class="front_clip"></div>
9393
<div class="back_clip"></div>
94-
<img class="slide-image" src="./assets/imgs/6.jpg" alt="BrickHack 6 attendees"/>
94+
<img src="./assets/imgs/6.jpg" class="slide-image" alt="BrickHack 6 attendees"/>
9595
</div>
9696
<div class="slide">
9797
<div class="wire"></div>
9898
<div class="front_clip"></div>
9999
<div class="back_clip"></div>
100-
<img class="slide-image" src="./assets/imgs/7.jpg" alt="BrickHack 6 attendees"/>
100+
<img src="./assets/imgs/7.jpg" class="slide-image" alt="BrickHack 6 attendees"/>
101101
</div>
102102
<div class="slide">
103103
<div class="wire"></div>
104104
<div class="front_clip"></div>
105105
<div class="back_clip"></div>
106-
<img class="slide-image" src="./assets/imgs/8.jpg" alt="BrickHack 6 attendees"/>
106+
<img src="./assets/imgs/8.jpg" class="slide-image" alt="BrickHack 6 attendees"/>
107107
</div>
108108
<div class="slide">
109109
<div class="wire"></div>
110110
<div class="front_clip"></div>
111111
<div class="back_clip"></div>
112-
<img class="slide-image" src="./assets/imgs/9.jpg" alt="BrickHack 6 attendees"/>
112+
<img src="./assets/imgs/9.jpg" class="slide-image" alt="BrickHack 6 attendees"/>
113113
</div>
114114
<div class="slide">
115115
<div class="wire"></div>
116116
<div class="front_clip"></div>
117117
<div class="back_clip"></div>
118-
<img class="slide-image" src="./assets/imgs/10.jpg" alt="BrickHack 6 attendees"/>
118+
<img src="./assets/imgs/10.jpg" class="slide-image" alt="BrickHack 6 attendees"/>
119119
</div>
120120
<div class="slide">
121121
<div class="wire"></div>
122122
<div class="front_clip"></div>
123123
<div class="back_clip"></div>
124-
<img class="slide-image" src="./assets/imgs/11.jpg" alt="BrickHack 6 attendees"/>
124+
<img src="./assets/imgs/11.jpg" class="slide-image" alt="BrickHack 6 attendees"/>
125125
</div>
126126
</div>
127127
<div id="modal">
128128
<span id="close"><i id="close" class="fas fa-times"></i></span>
129-
<img id="modal-content">
129+
<img id="modal-content" alt="image from carousel">
130130
</div>
131131
<div id="hackathon-content">
132132
<div id="hackathon-text">

index.js

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,12 +43,19 @@ $(document).on('click', '#close', function() {
4343
});
4444

4545
// Closes modal when window is clicked
46-
$(window).on('click', function() {
46+
$(window).on('click', function(event) {
4747
if (event.target == modal) {
4848
$('#modal').hide();
4949
}
5050
});
5151

52+
// Closes modal when esc key is pressed
53+
$(document).on('keydown', function(event) {
54+
if (event.key == "Escape") {
55+
$('#modal').hide();
56+
}
57+
});
58+
5259

5360
let card = document.getElementsByClassName("card");
5461
for (let i = 0; i < card.length; i++) {

sass/main.scss

Lines changed: 9 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -362,7 +362,12 @@ nav {
362362
}
363363

364364
#modal-content {
365+
position: absolute;
365366
margin: auto;
367+
top: 0;
368+
left: 0;
369+
right: 0;
370+
bottom: 0;
366371
display: block;
367372
width: 80%;
368373
max-width: 700px;
@@ -373,15 +378,15 @@ nav {
373378

374379
@keyframes zoom {
375380
from {transform:scale(0)}
376-
to {transform: scale(1);}
381+
to { transform: scale(1); }
377382
}
378383

379384
#close {
380385
position: absolute;
381-
top: 50px;
382-
right: 160px;
386+
top: 15px;
387+
right: 35px;
383388
color:white;
384-
font-size: 2em;
389+
font-size: 1.5em;
385390
font-weight: bold;
386391
transition: 0.3s;
387392
}
@@ -393,8 +398,6 @@ nav {
393398
cursor: pointer;
394399
}
395400

396-
397-
398401
#hackathon-content {
399402
display: flex;
400403
justify-content: space-between;
@@ -775,15 +778,6 @@ footer {
775778
width: 100%;
776779
}
777780
}
778-
#modal-content {
779-
width: 100%;
780-
}
781-
#close {
782-
top: 50px;
783-
right: 25px;
784-
color: white;
785-
font-size: 1.5em;
786-
}
787781
}
788782

789783
#faq #faq-wrapper #faq-cards {

0 commit comments

Comments
 (0)