Skip to content

Commit 770959f

Browse files
authored
Merge pull request #934 from codeRIT/whitespace-fix
Overriding Sass's min and max functions so it works with 0
2 parents 462181c + d0e7fd2 commit 770959f

1 file changed

Lines changed: 12 additions & 3 deletions

File tree

src/index.scss

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
@import url('https://fonts.googleapis.com/css2?family=Poppins:wght@100;200;300;400;500;600;700;800;900;1000&display=swap');
22

33
$blue: #465491;
4+
45
/*
56
tablet & mobile have the column layout
67
tablet has fixed widths and font sizes
@@ -21,6 +22,14 @@ $mobile-width: 720px;
2122
@media(max-width: #{$mobile-width}) { @content; }
2223
}
2324

25+
//override sass min() & max(), use css
26+
@function min($numbers...) {
27+
@return m#{i}n(#{$numbers});
28+
}
29+
@function max($numbers...) {
30+
@return m#{a}x(#{$numbers});
31+
}
32+
2433
a:hover {
2534
text-decoration: none;
2635
}
@@ -84,7 +93,7 @@ html, body, #root, #app, .full-height {
8493
/*68 px is the current height of the nav bar
8594
will think of a better way to structure this later*/
8695
width: default;
87-
height: unquote("max(68px, calc(35px + 10vh))");
96+
height: max(68px, calc(35px + 10vh));
8897
margin-left: 15px;
8998
}
9099
}
@@ -156,7 +165,7 @@ html, body, #root, #app, .full-height {
156165
high scaling for very tall devices
157166
*/
158167

159-
margin-bottom: unquote("max(calc(0px), calc(10vh - 40px), calc(30vh - 190px))");
168+
margin-bottom: max(1px, calc(10vh - 40px), calc(30vh - 190px));
160169
}
161170
}
162171
.section {
@@ -185,7 +194,7 @@ html, body, #root, #app, .full-height {
185194
@include mobile {
186195
/* slightly smaller hero img for shorter screens */
187196
min-width: 80%;
188-
width: unquote("min(50vh, 90%)");
197+
width: min(50vh, 90%);
189198
}
190199
}
191200

0 commit comments

Comments
 (0)