resolve issues mention by codeclimate and hound

Author: dquach217

app/controllers/manage/configs_controller.rb

@@ -19,14 +19,12 @@ def update
     value = false if value == "false"
     if @config.var.end_with?("_asset") && !value.start_with?('http://', 'https://')
       redirect_to manage_configs_path, notice: "Config \"#{key}\" was not changed"
-    else 
-      if @config.value != value
-        @config.value = value
-        @config.save
-        redirect_to manage_configs_path, notice: "Config \"#{key}\" has been updated."
-      else
-        redirect_to manage_configs_path, notice: "Config \"#{key}\" was not changed"
-      end
+    elsif @config.value != value
+      @config.value = value
+      @config.save
+      redirect_to manage_configs_path, notice: "Config \"#{key}\" has been updated."
+    else
+      redirect_to manage_configs_path, notice: "Config \"#{key}\" was not changed"
     end
   end
 

test/controllers/manage/configs_controller_test.rb

@@ -117,13 +117,13 @@ class Manage::ConfigsControllerTest < ActionController::TestCase
 
     should "update logo_asset with a url" do
       HackathonConfig["logo_asset"] = ''
-      patch :update, params: {id: "logo_asset", hackathon_config: { logo_asset: "https://picsum.photos/200" } }
+      patch :update, params: { id: "logo_asset", hackathon_config: { logo_asset: "https://picsum.photos/200" } }
       assert_equal "https://picsum.photos/200", HackathonConfig["logo_asset"]
     end
 
-    should "update logo_asset with an asset that is not URL based" do 
+    should "update logo_asset with an asset that is not URL based" do
       HackathonConfig["logo_asset"] = ''
-      patch :update, params: {id: "logo_asset", hackathon_config: { logo_asset: "test" } }
+      patch :update, params: { id: "logo_asset", hackathon_config: { logo_asset: "test" } }
       assert_equal '', HackathonConfig["logo_asset"]
     end