It would be preferable to use gitoxide's Git config implementation as it's surely more robust than what's currently in place. That should be considered as ad-hoc and a temporary workaround.
|
// TODO: figure out why this doesn't find the setting when used with `git -c` |
|
// let private_key_path = config.string("icp.privateKey").ok_or_else(|| { |
|
// anyhow!("failed to read icp.privateKey from git config. Set with `git config --global icp.privateKey <path to private key>`") |
|
// })?; |
@Byron – do you have any suggestions here? This isn't urgent but it would be a nice change (see below)
Once the custom config options we require in the icp namespace are confirmed as working using gitoxide (if possible) we should investigate if git -c http.proxy=http://localhost:9091 -c http.sslCAinfo=~/.proxyman/proxyman-ca.pem <command> then "just works" or if supporting that requires further changes.
It would be preferable to use gitoxide's Git config implementation as it's surely more robust than what's currently in place. That should be considered as ad-hoc and a temporary workaround.
git-remote-icp/crates/git-remote-helper/src/git/config/mod.rs
Lines 3 to 6 in c3f0f5c
@Byron – do you have any suggestions here? This isn't urgent but it would be a nice change (see below)
Once the custom config options we require in the
icpnamespace are confirmed as working using gitoxide (if possible) we should investigate ifgit -c http.proxy=http://localhost:9091 -c http.sslCAinfo=~/.proxyman/proxyman-ca.pem <command>then "just works" or if supporting that requires further changes.