Ansible12 fixes pr devel 1.x (#765)

* Php unix socket pr 1.x (#724)

* Moving cachetool adapter setup to the installer role and adding a test.

* Updating cachetool documentation.

* Php unix socket pr 1.x (#726)

* Moving cachetool adapter setup to the installer role and adding a test.

* Updating cachetool documentation.

* Making sure _cachetool_adapter is always set.

* Optional-drush-cr-before-import (#728)

* 73171 fixing cachetool checks fpm pr 1.x (#729)

* skipping cachetool check when no fpm

* remove empty line

---------

Co-authored-by: filip <filip.rupic@codeenigma.com>

* asg_management_fix_and_improve (#733)

* asg_management_fix_and_improve

* asg_management_fix_and_improve

* asg_management_fix_and_improve

* asg_management_fix_and_improve

* asg_management_fix_and_improve

* Adding-delay-opcache-status-check (#737)

* Adding-delay-opcache-status-check

* Removing-failed-when

* fix_var_name_for_asg_management (#739)

* replace_ansible_pause_module (#747)

* fix_asg_management_workaround_for_squashfs (#754)

* fix_asg_management_workaround_for_squashfs

* fix_asg_management_workaround_for_squashfs

* fix_asg_management_workaround_task_condition (#756)

* aws_profile_for_asg_management (#758)

* aws_profile_for_asg_management

* aws_profile_for_asg_management_case_with_default_profile_absent

* ansible_module_requires_too_much_perms_just_for_autoscaling_managemen… (#761)

* ansible_module_requires_too_much_perms_just_for_autoscaling_management_so_replacing_with_aws_cli_from_role

* fix condition

* asg_management_workaround_improve_fix_conditions

* remove extra line

* Updating 'default()' filter paths in _init as an initial test.

* Explicitly casting integers as strings for path creation.

* Over refactored the variable setting!

---------

Co-authored-by: drazenCE <140631110+drazenCE@users.noreply.github.com>
Co-authored-by: Filip Rupic <123341158+filiprupic@users.noreply.github.com>
Co-authored-by: filip <filip.rupic@codeenigma.com>
Co-authored-by: tymofiisobchenko <104431720+tymofiisobchenko@users.noreply.github.com>

Author: 5 people

roles/_init/tasks/drupal8.yml

@@ -1,15 +1,15 @@
 ---
 - name: Define path to drush for this build.
   ansible.builtin.set_fact:
-    drush_bin: "{{ drush_bin | default('{{ deploy_path }}/vendor/bin/drush') }}"
+    drush_bin: "{{ drush_bin | default(deploy_path + '/vendor/bin/drush') }}"
 
 - name: Define path to drush for previous build.
   ansible.builtin.set_fact:
-    previous_drush_bin: "{{ previous_drush_bin | default('{{ previous_deploy_path }}/vendor/bin/drush') }}"
+    previous_drush_bin: "{{ previous_drush_bin | default(previous_deploy_path + '/vendor/bin/drush') }}"
 
 - name: Define path to drush for currently live build.
   ansible.builtin.set_fact:
-    drush_live_bin: "{{ drush_live_bin | default('{{ live_symlink_dest }}/vendor/bin/drush') }}"
+    drush_live_bin: "{{ drush_live_bin | default(live_symlink_dest + '/vendor/bin/drush') }}"
 
 - name: Ensure we have a cachetool binary and configuration.
   ansible.builtin.import_role:

roles/_init/tasks/main.yml

@@ -30,34 +30,28 @@
   ansible.builtin.set_fact:
     deploy_user: "{{ deploy_user | default('deploy') }}"
 
-- name: Define deploy base path.
+- name: Define initial deploy paths.
   ansible.builtin.set_fact:
-    deploy_base_path: "{{ deploy_base_path | default('/home/{{ deploy_user }}/deploy/{{ project_name }}_{{ build_type }}') }}"
+    deploy_base_path: "{{ deploy_base_path | default('/home/' + deploy_user + '/deploy/' + project_name + '_' + build_type) }}"
+    deploy_assets_base_path: "{{ deploy_assets_base_path | default('/home/' + deploy_user + '/shared/' + project_name + '_' + build_type + '/assets') }}"
+    webroot: "{{ webroot | default('web') }}"
 
-- name: Define mounted directory for assets.
+- name: Define deploy_path_prefix variable.
   ansible.builtin.set_fact:
-    deploy_assets_base_path: "{{ deploy_assets_base_path | default('/home/{{ deploy_user }}/shared/{{ project_name }}_{{ build_type }}/assets') }}"
+    deploy_path_prefix: "{{ deploy_base_path }}/{{ project_name }}_{{ build_type }}_build_"
 
-- name: Define webroot.
+- name: Define final deploy_path variable.
   ansible.builtin.set_fact:
-    webroot: "{{ webroot | default('web') }}"
+    deploy_path: "{{ deploy_path | default(deploy_path_prefix + build_number|string) }}"
 
 # This is passed from caller.
 - name: Gather last known good build number.
   ansible.builtin.set_fact:
     previous_build_number: "{{ previous_known_build_number }}"
 
-- name: Define build deploy path prefix.
-  ansible.builtin.set_fact:
-    deploy_path_prefix: "{{ deploy_base_path }}/{{ project_name }}_{{ build_type }}_build_"
-
-- name: Define build deploy path.
-  ansible.builtin.set_fact:
-    deploy_path: "{{ deploy_path | default('{{ deploy_path_prefix }}{{ build_number }}') }}"
-
 - name: Define live_symlink dest.
   ansible.builtin.set_fact:
-    live_symlink_dest: "{{ live_symlink_dest | default('{{ deploy_base_path }}/live.{{ project_name }}_{{ build_type }}') }}"
+    live_symlink_dest: "{{ live_symlink_dest | default(deploy_base_path + '/live.' + project_name + '_' + build_type) }}"
 
 - name: Read the live symlink to get the path to the current build.
   ansible.builtin.stat:
@@ -85,7 +79,7 @@
         msg: "Track file ID: {{ previous_build_number }}. Build path ID: {{ _current_build_id }}. These should match, something is wrong, failing the build."
       when:
         - _current_build_path.stat.islnk
-        - _current_build_id | int != previous_build_number | int
+        - _current_build_id|int != previous_build_number|int
         - not skip_build_path_check
 
 - name: Define opcache cachetool path.
@@ -114,11 +108,11 @@
 
     - name: Define live_symlink dest for image builds.
       ansible.builtin.set_fact:
-        live_symlink_build_dest: "{{ live_symlink_build_dest | default('{{ build_base_path }}/live.{{ project_name }}_{{ build_type }}') }}"
+        live_symlink_build_dest: "{{ live_symlink_build_dest | default(build_base_path + '/live.' + project_name + '_' + build_type) }}"
 
     - name: Overwrite deploy and live_symlink paths if SquashFS deploy.
       ansible.builtin.set_fact:
-        deploy_path: "{{ build_path | default('{{ build_path_prefix }}{{ build_number }}') }}"
+        deploy_path: "{{ build_path | default(build_path_prefix + build_number|string) }}"
 
     - name: Overwrite cachetool path if SquashFS deploy and path not provided.
       ansible.builtin.set_fact:
@@ -206,7 +200,7 @@
 
 - name: Set the previous deploy's path for later use where we need to manipulate the live site.
   ansible.builtin.set_fact:
-    previous_deploy_path: "{{ previous_deploy_path | default('{{ deploy_path_prefix }}{{ previous_build_number }}') }}"
+    previous_deploy_path: "{{ previous_deploy_path | default(deploy_path_prefix + previous_build_number|string) }}"
 
 # Make sure the deploy target exists.
 - name: Ensure deploy target directory exists.