Revisit AbstractScanner.DEFAULT_EXCLUDES

[kwin]

In e8a8433 certain filename patterns have been removed from DEFAULT_EXCLUDES (raised in #71, included since plexus-utils 3.3.1). This has been partially reverted in 2f541fd (by again ignoring .gitignore, included since plexus-utils 4.0.1).

[kwin]

@slawekjaranowski Can you clarify why you have readded .gitignore in 2f541fd?

[slawekjaranowski]

It think that it was introduced after working on

• [MJAR-296] Allow including files excluded by default. apache/maven-jar-plugin#67
• [MJAR-296] Allow including files excluded by default. apache/maven-jar-plugin#67 (comment)

we still have similar: **/.cvsignore

https://github.com/codehaus-plexus/plexus-utils/blob/master/src/main/java/org/codehaus/plexus/util/AbstractScanner.java#L64C1-L65C1

but 3.x doesn't have .gitignore on list

https://github.com/codehaus-plexus/plexus-utils/blob/plexus-utils-3.x/src/main/java/org/codehaus/plexus/util/AbstractScanner.java#L108

so right we need revisit it, and make the same list in both branches master and 3.x

[kwin]

My argument for not including .gitignore and .gitattributes in the list is that maven-source-plugin would otherwise not include it, and sometimes this includes information also relevant for building (for example with https://creadur.apache.org/rat/apache-rat-plugin/check-mojo.html#parseSCMIgnoresAsExcludes, or in https://github.com/diffplug/spotless/tree/main/plugin-maven#line-endings-and-encodings-invisible-stuff), therefore I would opt to remove it from default excludes.

If they are not relevant for maven-jar-plugin that should be handled in that plugin specifically. In general one cannot say about those files that they should be excluded. Also https://maven.apache.org/plugins/maven-resources-plugin/resources-mojo.html#addDefaultExcludes needs probably to reconsider the default excludes.