Replace isset with array_key_exists

scoumbourdis · scoumbourdis · commit d8eacab7f34b · 2018-07-03T10:46:05.000+03:00
diff --git a/application/libraries/Grocery_CRUD.php b/application/libraries/Grocery_CRUD.php
@@ -950,7 +950,7 @@ protected function db_insert($state_info)
 						$post_data[$field->field_name] = array();
 					}
 
-					if(isset($post_data[$field->field_name]) && !isset($this->relation_n_n[$field->field_name]))
+					if(array_key_exists($field->field_name, $post_data) && !isset($this->relation_n_n[$field->field_name]))
 					{
 						if(isset($types[$field->field_name]->db_null) && $types[$field->field_name]->db_null && is_array($post_data[$field->field_name]) && empty($post_data[$field->field_name]))
 						{
@@ -1075,7 +1075,7 @@ protected function db_update($state_info)
 						$post_data[$field->field_name] = array();
 					}
 
-					if(isset($post_data[$field->field_name]) && !isset($this->relation_n_n[$field->field_name]))
+					if(array_key_exists($field->field_name, $post_data) && !isset($this->relation_n_n[$field->field_name]))
 					{
 						if(isset($types[$field->field_name]->db_null) && $types[$field->field_name]->db_null && is_array($post_data[$field->field_name]) && empty($post_data[$field->field_name]))
 						{

Original file line number	Diff line number	Diff line change
`@@ -950,7 +950,7 @@ protected function db_insert($state_info)`
`950`	`950`	`$post_data[$field->field_name] = array();`
`951`	`951`	`}`
`952`	`952`
`953`		`- if(isset($post_data[$field->field_name]) && !isset($this->relation_n_n[$field->field_name]))`
	`953`	`+ if(array_key_exists($field->field_name, $post_data) && !isset($this->relation_n_n[$field->field_name]))`
`954`	`954`	`{`
`955`	`955`	`if(isset($types[$field->field_name]->db_null) && $types[$field->field_name]->db_null && is_array($post_data[$field->field_name]) && empty($post_data[$field->field_name]))`
`956`	`956`	`{`
`@@ -1075,7 +1075,7 @@ protected function db_update($state_info)`
`1075`	`1075`	`$post_data[$field->field_name] = array();`
`1076`	`1076`	`}`
`1077`	`1077`
`1078`		`- if(isset($post_data[$field->field_name]) && !isset($this->relation_n_n[$field->field_name]))`
	`1078`	`+ if(array_key_exists($field->field_name, $post_data) && !isset($this->relation_n_n[$field->field_name]))`
`1079`	`1079`	`{`
`1080`	`1080`	`if(isset($types[$field->field_name]->db_null) && $types[$field->field_name]->db_null && is_array($post_data[$field->field_name]) && empty($post_data[$field->field_name]))`
`1081`	`1081`	`{`