Restoring checks now that redirects should be fixed

Author: shai-almog

.github/workflows/website-docs.yml

@@ -91,22 +91,22 @@ jobs:
           CN1_USER: ${{ secrets.CN1_USER }}
           CN1_TOKEN: ${{ secrets.CN1_TOKEN }}
 
-#      - name: Validate Initializr page output
-#        run: |
-#          set -euo pipefail
-#          test -f docs/website/public/initializr/index.html
-
-#      - name: Validate Initializr JS bundle output
-#        run: |
-#          set -euo pipefail
-#          if [ -n "${CN1_USER}" ] && [ -n "${CN1_TOKEN}" ]; then
-#            test -f docs/website/public/initializr-app/index.html
-#          else
-#            echo "CN1 credentials not configured; skipping Initializr JS bundle output validation."
-#          fi
-#        env:
-#          CN1_USER: ${{ secrets.CN1_USER }}
-#          CN1_TOKEN: ${{ secrets.CN1_TOKEN }}
+      - name: Validate Initializr page output
+        run: |
+          set -euo pipefail
+          test -f docs/website/public/initializr/index.html
+
+      - name: Validate Initializr JS bundle output
+        run: |
+          set -euo pipefail
+          if [ -n "${CN1_USER}" ] && [ -n "${CN1_TOKEN}" ]; then
+            test -f docs/website/public/initializr-app/index.html
+          else
+            echo "CN1 credentials not configured; skipping Initializr JS bundle output validation."
+          fi
+        env:
+          CN1_USER: ${{ secrets.CN1_USER }}
+          CN1_TOKEN: ${{ secrets.CN1_TOKEN }}
 
       - name: Validate redirects against local Pages runtime
         run: |
@@ -143,29 +143,29 @@ jobs:
             --redirects-file docs/website/public/_redirects \
             --skip-auto-cases
 
-#      - name: Validate internal links and images
-#        uses: lycheeverse/lychee-action@v2
-#        with:
-#          lycheeVersion: latest
-#          workingDirectory: docs/website
-#          args: >-
-#            --offline
-#            --no-progress
-#            --root-dir public
-#            public/**/*.html
-
-#      - name: Reject absolute codenameone.com links
-#        run: |
-#          set -euo pipefail
-#          report="docs/website/reports/disallowed-codenameone-links.txt"
-#          mkdir -p "$(dirname "$report")"
-#          rg -n --no-heading -S '\]\((https?:)?//(www\.)?codenameone\.com([/:?#)]|$)|<https?://(www\.)?codenameone\.com([/:?#>]|$)|(href|src)=["'"'"']https?://(www\.)?codenameone\.com([/:?#]|$)' \
-#            docs/website/content docs/website/layouts docs/website/static > "$report" || true
-#          if [ -s "$report" ]; then
-#            echo "Disallowed absolute codenameone.com links found (use relative URLs or non-www subdomains):" >&2
-#            sed -n '1,200p' "$report" >&2
-#            exit 1
-#          fi
+      - name: Validate internal links and images
+        uses: lycheeverse/lychee-action@v2
+        with:
+          lycheeVersion: latest
+          workingDirectory: docs/website
+          args: >-
+            --offline
+            --no-progress
+            --root-dir public
+            public/**/*.html
+
+      - name: Reject absolute codenameone.com links
+        run: |
+          set -euo pipefail
+          report="docs/website/reports/disallowed-codenameone-links.txt"
+          mkdir -p "$(dirname "$report")"
+          rg -n --no-heading -S '\]\((https?:)?//(www\.)?codenameone\.com([/:?#)]|$)|<https?://(www\.)?codenameone\.com([/:?#>]|$)|(href|src)=["'"'"']https?://(www\.)?codenameone\.com([/:?#]|$)' \
+            docs/website/content docs/website/layouts docs/website/static > "$report" || true
+          if [ -s "$report" ]; then
+            echo "Disallowed absolute codenameone.com links found (use relative URLs or non-www subdomains):" >&2
+            sed -n '1,200p' "$report" >&2
+            exit 1
+          fi
 
       - name: Upload codenameone link policy report
         if: ${{ always() }}

scripts/website/build.sh

@@ -468,9 +468,9 @@ build_initializr_for_site() {
 
     run_initializr_mvn() {
       if command -v xvfb-run >/dev/null 2>&1; then
-        xvfb-run -a ./mvnw "$@" || true
+        xvfb-run -a ./mvnw "$@"
       else
-        ./mvnw "$@" || true
+        ./mvnw "$@"
       fi
     }
 
@@ -484,14 +484,14 @@ build_initializr_for_site() {
     run_initializr_mvn -q -U -pl cn1libs/ZipSupport -am \
       -DskipTests \
       -Dcodename1.platform=javascript \
-      install  || true
+      install
 
     if [ -n "${CN1_USER}" ] && [ -n "${CN1_TOKEN}" ]; then
       if ! run_initializr_mvn -q -U -pl javascript -am \
         cn1:set-user-token \
         -Dcodename1.platform=javascript \
         -Duser="${CN1_USER}" \
-        -Dtoken="${CN1_TOKEN}"  || true; then
+        -Dtoken="${CN1_TOKEN}"; then
         echo "cn1:set-user-token is unavailable in this plugin version; writing CN1 credentials directly to Java preferences." >&2
         local tmp_dir
         tmp_dir="$(mktemp -d)"
@@ -521,7 +521,7 @@ JAVA
       -DskipTests \
       -Dautomated=true \
       -Dcodename1.platform=javascript \
-      package  || true
+      package
   )
 
   local output_dir="${WEBSITE_DIR}/static/initializr-app"
@@ -530,19 +530,19 @@ JAVA
     result_zip="$(ls -1 "${REPO_ROOT}"/scripts/initializr/javascript/target/initializr-javascript-*.zip 2>/dev/null | head -n1 || true)"
   fi
 
-  #if [ -z "${result_zip}" ] || [ ! -f "${result_zip}" ]; then
-  #  echo "Could not locate Initializr JavaScript build zip output in scripts/initializr/javascript/target." >&2
-  #  exit 1
-  #fi
+  if [ -z "${result_zip}" ] || [ ! -f "${result_zip}" ]; then
+    echo "Could not locate Initializr JavaScript build zip output in scripts/initializr/javascript/target." >&2
+    exit 1
+  fi
 
-  #rm -rf "${output_dir}"
-  #mkdir -p "${output_dir}"
-  #unzip -q -o "${result_zip}" -d "${output_dir}"
+  rm -rf "${output_dir}"
+  mkdir -p "${output_dir}"
+  unzip -q -o "${result_zip}" -d "${output_dir}"
 
-  #if [ ! -f "${output_dir}/index.html" ]; then
-  #  echo "Initializr website bundle is missing index.html after extraction." >&2
-  #  exit 1
-  #fi
+  if [ ! -f "${output_dir}/index.html" ]; then
+    echo "Initializr website bundle is missing index.html after extraction." >&2
+    exit 1
+  fi
 }
 
 if ! command -v "${HUGO_BIN}" >/dev/null 2>&1; then