Return early when regex is empty

Author: Bastian Schwarz

src/taskMatcher/ByRegexTaskName.php

@@ -27,6 +27,6 @@ final class ByRegexTaskName implements iTaskMatcher {
   public function __construct(public string $regex) {}
 
   public function matches(Task $task) : bool {
-    return preg_match($this->regex, $task->getName()) === 1;
+    return $this->regex !== '' && preg_match($this->regex, $task->getName()) === 1;
   }
-}
+}

test/taskMatcher/ByRegexTaskNameTest.php

@@ -49,6 +49,15 @@ public function testMatches() : void {
     self::assertFalse($this->sut->matches($task4));
   }
 
+  public function testMatches_canReturnFalse_whenRegexIsEmpty() : void {
+    $this->sut->regex = '';
+
+    $task1 = $this->createMock(Task::class);
+    $task1->expects(self::never())->method('getName');
+
+    self::assertFalse($this->sut->matches($task1));
+  }
+
   public function test__construct() : void {
     $regex = 'some regex';