Created a client factory. We cannot use the client directly because the middleware stack of guzzle contains closures that cannot be serialized when passing them between async processes

Author: bastianschwarz

packages/http/src/Check/HttpCheck.php

@@ -22,7 +22,8 @@
 use de\codenamephp\deploymentchecks\base\Check\WithNameInterface;
 use de\codenamephp\deploymentchecks\http\Check\Result\HttpCheckResult;
 use de\codenamephp\deploymentchecks\http\Check\Test\TestInterface;
-use GuzzleHttp\Client;
+use de\codenamephp\deploymentchecks\http\ClientFactory\ClientFactoryInterface;
+use de\codenamephp\deploymentchecks\http\ClientFactory\GuzzleClient;
 use Psr\Http\Message\RequestInterface;
 
 final class HttpCheck implements CheckInterface, WithNameInterface {
@@ -32,21 +33,23 @@ final class HttpCheck implements CheckInterface, WithNameInterface {
    */
   public array $tests = [];
 
+  public ClientFactoryInterface $clientFactory;
+
   public function __construct(
     public readonly RequestInterface $request,
     public readonly string $name,
     TestInterface ...$tests
   ) {
     $this->tests = $tests;
+    $this->clientFactory = new GuzzleClient();
   }
 
   public function name() : string {
     return $this->name;
   }
 
   public function run() : ResultInterface {
-    $client = new Client();
-    $response = $client->send($this->request);
+    $response = $this->clientFactory->create()->send($this->request);
     return new HttpCheckResult($this->name(), ...array_map(fn(TestInterface $test) => $test->test($response), $this->tests));
   }
 }

packages/http/src/ClientFactory/ClientFactoryInterface.php

@@ -0,0 +1,25 @@
+<?php declare(strict_types=1);
+/*
+ *  Copyright 2023 Bastian Schwarz <bastian@codename-php.de>.
+ *
+ *  Licensed under the Apache License, Version 2.0 (the "License");
+ *  you may not use this file except in compliance with the License.
+ *  You may obtain a copy of the License at
+ *
+ *        http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *  Unless required by applicable law or agreed to in writing, software
+ *  distributed under the License is distributed on an "AS IS" BASIS,
+ *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *  See the License for the specific language governing permissions and
+ *  limitations under the License.
+ */
+
+namespace de\codenamephp\deploymentchecks\http\ClientFactory;
+
+use Psr\Http\Client\ClientInterface;
+
+interface ClientFactoryInterface {
+
+  public function create() : ClientInterface;
+}

packages/http/src/ClientFactory/GuzzleClient.php

@@ -0,0 +1,38 @@
+<?php declare(strict_types=1);
+/*
+ *  Copyright 2023 Bastian Schwarz <bastian@codename-php.de>.
+ *
+ *  Licensed under the Apache License, Version 2.0 (the "License");
+ *  you may not use this file except in compliance with the License.
+ *  You may obtain a copy of the License at
+ *
+ *        http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *  Unless required by applicable law or agreed to in writing, software
+ *  distributed under the License is distributed on an "AS IS" BASIS,
+ *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *  See the License for the specific language governing permissions and
+ *  limitations under the License.
+ */
+
+namespace de\codenamephp\deploymentchecks\http\ClientFactory;
+
+use GuzzleHttp\Client;
+use Psr\Http\Client\ClientInterface;
+
+final class GuzzleClient implements ClientFactoryInterface {
+
+  public function __construct(public readonly array $config = []) {}
+
+  public function create() : ClientInterface {
+    return new Client($this->config);
+  }
+
+  public function withConfig(array $config) : self {
+    return new self($config);
+  }
+
+  public function withMergedOptions(array $config) : self {
+    return new self(array_merge($this->config, $config));
+  }
+}