Skip to content

Commit 9e03f53

Browse files
resolving suggested fixed
1 parent 348b569 commit 9e03f53

3 files changed

Lines changed: 31 additions & 14 deletions

File tree

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,16 @@
11

22
# Pull Request Template
33

4-
**script name** -
5-
64
**What have you Changed**
75

86
what you changed in the codebase.write here
97

108

11-
### Issue no.(must) - #
9+
### Issue No. closes #
1210

1311
### Self Check(Tick After Making pull Request)
1412

15-
- [ ] This issue was assigned to me.
16-
- [x] One Change in one Pull Request
17-
- [x] My file is in proper folder
18-
- [x] I am following clean code and Documentation and my code is well linted with flake8.
19-
- [ ] I have added README.md and requirements.txt with my script
20-
21-
If issue was not assigned to you Please don't make a PR. It will marked as invalid.
13+
- [ ] One Change in one Pull Request
14+
- [ ] I am following clean code and Documentation and my code is well linted with flake8.
2215

2316
Join Us on Discord:- https://discord.gg/JfbK3bS

CHANGELOG.md

Lines changed: 22 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,28 @@
22

33
All notable changes to this project will be documented in this file. The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
44

5-
## [Initial Release]
5+
## [1.0.5] - 02-11-2022
6+
7+
- PYPI package is now available
8+
- Only create required directories
9+
- Package can be updated from Github action workflow
10+
11+
## [1.0.4] - 04-07-2022
12+
13+
- code refactoring
14+
- bug fixes
15+
16+
## [1.0.3] - 23-09-2020
17+
18+
- Bug Fixed
19+
20+
## [1.0.2] - 22-09-2020
21+
22+
- New Extension Added
23+
- Bug Fixed
24+
25+
26+
## [Initial Release] - 13/05/2020
627

728
- Initial Release
829

filemover/main.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -56,9 +56,11 @@ def move_files(folder_path:str, file_folder_map: dict):
5656
ext_file_map (dict) : File to Folder map
5757
'''
5858
for folder, files in file_folder_map.items():
59+
os.makedirs(os.path.join(folder_path, folder), exist_ok=True)
5960
for file in files:
60-
os.makedirs(os.path.join(folder_path, folder), exist_ok=True)
61-
move(os.path.join(folder_path, file), os.path.join(folder_path, folder))
61+
old_file_path = os.path.join(folder_path, file)
62+
new_file_path = os.path.join(folder_path, folder)
63+
move(old_file_path, new_file_path)
6264

6365

6466
def get_folder(ext):
@@ -77,7 +79,8 @@ def get_folder(ext):
7779
return 'Other'
7880

7981

80-
def start(folder_path: str): # need to change function name
82+
# TODO need to change function name
83+
def start(folder_path: str):
8184
'''
8285
Organize files on the current directory, each to the corresponding folder.
8386

0 commit comments

Comments
 (0)