test(telemetry): drop warn-mock assertions for behavior-only tests

Aligns the older `setProperty`/`setMeasurement` post-emit test with the
new log/logError and phase tests: assert on observable behavior (no
event leak, fn still runs) rather than on `logger.warn` mock calls.

The warn itself is a developer aid for escaped-span bugs and stays in
production; only the test coupling is removed. Brief comment added on
`warnPostEmit` to record the intent.

Author: EhabY

src/telemetry/service.ts

@@ -176,6 +176,7 @@ export class TelemetryService implements vscode.Disposable, TelemetryReporter {
 		let completed = false;
 		// `markFailure` wins over `markAborted` regardless of call order.
 		let mark: "aborted" | "error" | undefined;
+		// Surfaces escaped-span bugs in the dev console. The drop is tested; the warn is not.
 		const warnPostEmit = (op: string, name: string): void => {
 			this.logger.warn(
 				`Telemetry span '${eventName}' ${op}('${name}') called after emit; mutation dropped`,

test/unit/telemetry/service.test.ts

@@ -370,40 +370,23 @@ describe("TelemetryService", () => {
 			expect(phase.eventName).toBe("op.bad_name");
 		});
 
-		it("warns and ignores setProperty/setMeasurement called after emit", async () => {
+		it("drops setProperty/setMeasurement/markAborted/markFailure called after emit", async () => {
 			let escapedSpan: Span | undefined;
 			await h.service.trace("op", (span) => {
 				escapedSpan = span;
 				return Promise.resolve();
 			});
 
 			expect(h.sink.events).toHaveLength(1);
-			const warnBefore = vi.mocked(h.logger.warn).mock.calls.length;
 
 			escapedSpan?.setProperty("late", "ignored");
 			escapedSpan?.setMeasurement("lateMs", 99);
 			escapedSpan?.markAborted();
 			escapedSpan?.markFailure();
 
-			// Mutations dropped: emitted event is unchanged.
 			expect(h.sink.events[0].properties.late).toBeUndefined();
 			expect(h.sink.events[0].measurements.lateMs).toBeUndefined();
 			expect(h.sink.events[0].properties.result).toBe("success");
-
-			// Each post-emit mutation logs a warning.
-			expect(vi.mocked(h.logger.warn).mock.calls.length).toBe(warnBefore + 4);
-			expect(vi.mocked(h.logger.warn).mock.calls[warnBefore][0]).toContain(
-				"setProperty",
-			);
-			expect(vi.mocked(h.logger.warn).mock.calls[warnBefore + 1][0]).toContain(
-				"setMeasurement",
-			);
-			expect(vi.mocked(h.logger.warn).mock.calls[warnBefore + 2][0]).toContain(
-				"markAborted",
-			);
-			expect(vi.mocked(h.logger.warn).mock.calls[warnBefore + 3][0]).toContain(
-				"markFailure",
-			);
 		});
 
 		it("drops span logs called after emit", async () => {