fix: show a message instead of hiding the shared workspaces view

Toggling view visibility based on coder.sharedWorkspacesSupported raced
the manual refresh command's context flip, causing the view to flicker
on and off across refreshes. The view is now always shown when
authenticated, with viewsWelcome explaining when shared workspaces
aren't supported or the list is empty.

Author: EhabY

CHANGELOG.md

@@ -7,6 +7,14 @@
 
 ## Unreleased
 
+### Changed
+
+- Filter the Shared Workspaces view with the server-side `shared_with_user`
+  query instead of filtering `shared:true` results on the client, so fewer
+  workspaces are fetched and the view loads faster. Deployments too old to
+  support the new filter now show a message explaining why instead of an
+  empty list.
+
 ### Fixed
 
 - Apply a 60-second default timeout to REST requests, so requests hung on a

package.json

@@ -325,7 +325,7 @@
 					"visibility": "visible",
 					"icon": "media/logo-white.svg",
 					"initialSize": 1,
-					"when": "coder.authenticated && coder.sharedWorkspacesSupported"
+					"when": "coder.authenticated"
 				},
 				{
 					"id": "allWorkspaces",
@@ -371,6 +371,16 @@
 				"view": "coder.tasksLogin",
 				"contents": "Sign in to view and manage Coder tasks.\n[Login](command:coder.login)",
 				"when": "!coder.authenticated && coder.loaded"
+			},
+			{
+				"view": "sharedWorkspaces",
+				"contents": "Shared workspaces require Coder 2.27.0 or newer.",
+				"when": "coder.authenticated && !coder.sharedWorkspacesSupported"
+			},
+			{
+				"view": "sharedWorkspaces",
+				"contents": "No workspaces have been shared with you.",
+				"when": "coder.authenticated && coder.sharedWorkspacesSupported"
 			}
 		],
 		"commands": [

src/extension.ts

@@ -185,17 +185,16 @@ async function doActivate(
 		output,
 		deploymentManager.session,
 		{
-			// Deployments older than 2.27.0 reject the shared workspaces query;
-			// hide the view for them (see `when` in package.json).
+			// Older deployments reject this query; show a message instead of an
+			// empty tree (see `viewsWelcome` in package.json).
 			onQueryRejected: () =>
 				contextManager.set("coder.sharedWorkspacesSupported", false),
 		},
 	);
 	ctx.subscriptions.push(sharedWorkspacesProvider);
 
-	// Re-probe shared workspaces support whenever the session changes (login,
-	// logout, deployment switch): the view re-appears and the next fetch hides
-	// it again if the deployment still does not support the query.
+	// Re-probe support on session change (login, logout, deployment switch);
+	// the next fetch clears the message again if still unsupported.
 	ctx.subscriptions.push(
 		deploymentManager.session.onDidChange(() =>
 			contextManager.set("coder.sharedWorkspacesSupported", true),
@@ -334,8 +333,8 @@ async function doActivate(
 		commands.navigateToWorkspaceSettings.bind(commands),
 	);
 	commandManager.register("coder.refreshWorkspaces", () => {
-		// Re-probe shared workspaces support in case the deployment was upgraded;
-		// showing the view triggers its fetch, which hides it again on rejection.
+		// Re-probe in case the deployment was upgraded; the fetch below clears
+		// the message again on rejection.
 		contextManager.set("coder.sharedWorkspacesSupported", true);
 		void myWorkspacesProvider.fetchAndRefresh();
 		void sharedWorkspacesProvider.fetchAndRefresh();