Skip to content

Commit 8484b3e

Browse files
committed
content/code-review: Minor updates
1 parent e2f4741 commit 8484b3e

1 file changed

Lines changed: 12 additions & 3 deletions

File tree

content/code-review.md

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,16 +36,25 @@ previous episode.
3636
deliberately introduce a typo and also a larger mistake which we will want to fix during the code review.
3737
1. Open a pull request towards the main branch.
3838
1. As a reviewer to somebody else's pull request, ask for an improvement and
39-
also directly suggest a change for the small typo.
40-
1. As the submitter, learn how to accept the suggested change.
39+
also directly suggest a change for the small typo. (Hint:
40+
suggestions are possible through the GitHub web interface, view of
41+
a pull request, "Files changed" view, after selecting some lines.
42+
Look for the "±" button.)
43+
1. As the submitter, learn how to accept the suggested change. (Hint:
44+
GitHub web interface, "Files Changed" view.)
4145
1. As the submitter, improve the pull request without having to close and open
42-
a new one: by adding a new commit to the same branch.
46+
a new one: by adding a new commit to the same branch. (Hint: push
47+
to the branch again.)
4348
1. Once the changes are addressed, merge the pull request.
4449
:::
4550

4651

4752
## Help and discussion
4853

54+
From here on out, we don't give detailed steps to the solution. You
55+
need to combine what you know, and the extra info below, in order to
56+
solve the above.
57+
4958
### How to ask for changes in a pull request
5059

5160
Technically, there are at least two common ways to ask for changes in a pull

0 commit comments

Comments
 (0)