Skip to content

Commit efcdfad

Browse files
authored
Merge pull request #302 from coderefinery/radovan/code-review
minor improvements (emphasis) in the code review episode
2 parents bea4515 + a4ac278 commit efcdfad

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

content/code-review.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ ask for changes in a pull request, how to suggest a change in a pull request,
55
and how to modify a pull request.
66

77
This will enable research groups to work more collaboratively and to not only
8-
improve the code quality but also to learn from each other.
8+
improve the code quality but also to **learn from each other**.
99

1010

1111
## Exercise
@@ -120,7 +120,7 @@ and later open a new one. It can even be counter-productive to do so: This can
120120
fragment the discussion and the history of the pull request and can make it
121121
harder to understand the context of the changes.
122122

123-
A much better mechanism to recognize that pull requests are not implemented
123+
A much better mechanism is to recognize that pull requests are not implemented
124124
from a specific commit to a specific branch, but **always from a branch to a
125125
branch**.
126126

@@ -129,7 +129,7 @@ commits to the same source branch. This way the pull request will be updated
129129
automatically and the reviewer can see the new changes and comment on them.
130130

131131
The fact that pull requests are from branch to branch also strongly suggests
132-
that it is a good practice to create a new branch for each pull request.
132+
that it is a good practice to **create a new branch for each pull request**.
133133
Otherwise you could accidentally modify an open pull request by adding new
134134
commits to the source branch.
135135

@@ -138,5 +138,5 @@ commits to the source branch.
138138

139139
- Our process isn't just about code now. It's about discussion and
140140
working together to make the whole process better.
141-
- GitHub discussions and reviewing is quite powerful and can make
141+
- GitHub (or GitLab) discussions and reviewing are quite powerful and can make
142142
small changes easy.

0 commit comments

Comments
 (0)