Skip to content

Commit 1c4a7c6

Browse files
committed
switched setPreference to handleJSONResponse & moved error message to the server
1 parent 37a0f7f commit 1c4a7c6

2 files changed

Lines changed: 3 additions & 6 deletions

File tree

app/assets/javascripts/qpixel_api.js

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -238,13 +238,9 @@ window.QPixel = {
238238

239239
const data = await resp.json();
240240

241-
if (data.status !== 'success') {
242-
console.error(`Preference persist failed (${name})`);
243-
console.error(resp);
244-
}
245-
else {
241+
QPixel.handleJSONResponse(data, (data) => {
246242
QPixel._updatePreferencesLocally(data.preferences);
247-
}
243+
});
248244
},
249245

250246
filters: async () => {

app/controllers/users_controller.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -198,6 +198,7 @@ def set_preference
198198
preferences: current_user.preferences }
199199
else
200200
render json: { status: 'failed',
201+
message: 'Failed to save the preference',
201202
errors: ['Both name and value parameters are required'] },
202203
status: 400
203204
end

0 commit comments

Comments
 (0)