Create detached comment threads

Author: luap42

app/helpers/categories_helper.rb

@@ -7,19 +7,19 @@ def active?(category)
 
   def expandable?
     (defined?(@category) && !@category.nil? && !@category.id.nil? && !current_page?(new_category_url)) ||
-      (defined?(@post) && !@post.category.nil?) ||
-      (defined?(@question) && !@question.category.nil?) ||
-      (defined?(@article) && !@article.category.nil?)
+      (defined?(@post) && !@post&.category.nil?) ||
+      (defined?(@question) && !@question&.category.nil?) ||
+      (defined?(@article) && !@article&.category.nil?)
   end
 
   def current_category
     @current_category ||= if defined?(@category) && !@category.nil? && !@category.id.nil?
                             @category
-                          elsif defined?(@post) && !@post.category.nil?
+                          elsif defined?(@post) && !@post&.category.nil?
                             @post.category
-                          elsif defined?(@question) && !@question.category.nil?
+                          elsif defined?(@question) && !@question&.category.nil?
                             @question.category
-                          elsif defined?(@article) && !@article.category.nil?
+                          elsif defined?(@article) && !@article&.category.nil?
                             @article.category
                           end
   end

app/helpers/comments_helper.rb

@@ -55,6 +55,7 @@ def render_comment_helpers(comment_text, user = current_user)
 
   def get_pingable(thread)
     post = thread.post
+    return [] unless post.present? # Detached threads do not support individual pings
 
     # post author +
     # answer authors +

app/views/comments/thread.html.erb

@@ -1,5 +1,6 @@
 <% pingable = get_pingable(@comment_thread) %>
 
+<% if @post.present? %>
 <% if @post.parent.present? %>
   <details>
     <summary>Parent</summary>
@@ -15,6 +16,9 @@
 <h1>Comments on
   <a href="<%= generic_share_link(@post) %>"><%= @post.title.blank? && @post.parent.present? ? @post.parent.title : @post.title %></a>
 </h1>
+<% else %>
+<h1>Private Notification</h1>
+<% end %>
 
 <!-- THREAD STARTS BELOW -->
 <div class="<%= @comment_thread.deleted ? 'h-bg-red-050' : '' %> <%= params[:inline] == 'true' ? 'post--comments-thread is-embedded' : '' %>">
@@ -115,27 +119,27 @@
   <% unless current_user.nil? || params[:inline] == 'true' %>
     <div class="widget--footer">
       <% if !@comment_thread.read_only? %>
-        <% if @post.locked? && !moderator? && !admin? %>
+        <% if @post.present? && @post.locked? && !moderator? && !admin? %>
           <p class="has-color-tertiary-500">Comments are disabled on locked posts.</p>
-        <% elsif @post.deleted %>
+        <% elsif @post.present? && @post.deleted %>
           <p class="has-color-tertiary-500">Comments are disabled on deleted posts.</p>
-        <% elsif @post.comments_disabled && !moderator? && !admin? %>
+        <% elsif @post.present? && @post.comments_disabled && !moderator? && !admin? %>
           <p class="has-color-red-500"><i class="fa fa-lock"></i> Comments have been disabled on the parent post.</p>
         <% else %>
-          <% if @post.locked? %>
+          <% if @post.present? && @post.locked? %>
             <p class="has-color-red-500"><i class="fa fa-lock"></i> Comments are disabled on locked posts, but as a moderator you are exempt from that block.</p>
-          <% elsif @post.comments_disabled %>
+          <% elsif @post.present? && @post.comments_disabled %>
             <p class="has-color-red-500"><i class="fa fa-lock"></i> Comments have been disabled on this post, but as a moderator you are exempt from that block.</p>
           <% end %>
           <h4>Reply to this thread</h4>
           <%= form_tag create_comment_path(@comment_thread.id) do %>
-            <%= hidden_field_tag :post_id, @post.id %>
+            <%= hidden_field_tag :post_id, @post&.id %>
 
             <%= label_tag :content, 'Your message', class: 'form-element' %>
             <%= text_area_tag :content, '', class: 'form-element js-comment-field',
-                              data: { thread: @comment_thread.id, post: @comment_thread.post_id,
-                                      character_count: ".js-character-count-#{@post.id}" } %>
-            <span class="has-float-right has-font-size-caption js-character-count-<%= @post.id %>"
+                              data: { thread: @comment_thread.id, post: @post&.id,
+                                      character_count: ".js-character-count-#{@post&.id}" } %>
+            <span class="has-float-right has-font-size-caption js-character-count-<%= @post&.id %>"
                   data-max="1000" data-min="15">
               <i class="fas fa-ellipsis-h js-character-count__icon"></i>
               <span class="js-character-count__count">0 / 1000</span>