minor cleanup of the client-side stripMarkdown helper

Author: Oaphi

app/assets/javascripts/character_count.js

@@ -67,7 +67,7 @@ $(() => {
 
     const fullCount = $tgt.val().trim().length;
     const count = omitMarkdown ?
-                    QPixel.MD.stripMarkdown($tgt.val().trim(), { removeQuotes: true }).length :
+                    QPixel.MD.stripMarkdown($tgt.val().trim(), { removeLeadingQuote: true }).length :
                     fullCount;
 
     $info.toggleClass('hide', fullCount === count)

app/assets/javascripts/qpixel_markdown.js

@@ -7,7 +7,7 @@ QPixel.MD = {
       .replace(/[*_~]+/g, '')
       .replace(/!?\[([^\]]+)\](?:\([^)]+\)|\[[^\]]+\])/g, '$1');
 
-    if (options.removeQuotes) {
+    if (options.removeLeadingQuote ?? false) {
       return stripped.replace(/^>.+?$/g, '');
     }
 

global.d.ts

@@ -37,13 +37,19 @@ interface QPixelDOM {
   setVisible?: (elements: HTMLElement | HTMLElement[], visible: boolean) => void;
 }
 
+interface StripMarkdownOptions {
+  /**
+   * Whether to strip away the leading quote ("> content"), if any
+   * @default false
+   */
+  removeLeadingQuote?: boolean
+}
+
 interface QPixelMD {
   /**
-   * See [strip_markdown](./app/helpers/application_helper.rb) application helper
+   * See [strip_markdown](app/helpers/application_helper.rb) application helper
    */
-  stripMarkdown(content: string, options?: {
-    removeQuotes?: boolean
-  }): string;
+  stripMarkdown(content: string, options?: StripMarkdownOptions): string;
 }
 
 type QPixelKeyboardState =