Merge pull request #1675 from codidact/0valt/1674/user-sorting

fixed default sort param for user searches

Author: Oaphi

app/controllers/users_controller.rb

@@ -15,7 +15,7 @@ class UsersController < ApplicationController
   before_action :check_deleted, only: [:show, :posts, :activity]
 
   def index
-    sort_param = { reputation: :reputation, age: :created_at }[params[:sort]&.to_sym] || :reputation
+    @sort_param = { reputation: :reputation, age: :created_at }[params[:sort]&.to_sym] || :reputation
 
     @users = if params[:search].present?
                user_scope.search(params[:search])
@@ -25,7 +25,7 @@ def index
 
     @users = @users.where.not(deleted: true)
                    .where.not(community_users: { deleted: true })
-                   .order(sort_param => :desc)
+                   .order(@sort_param => :desc)
                    .paginate(page: params[:page], per_page: 48)
 
     @post_counts = Post.where(user_id: @users.pluck(:id).uniq).group(:user_id).count

app/views/users/index.html.erb

@@ -7,7 +7,7 @@
     <div class="form-group">
       <%= label_tag :search, "Search", class: "form-element" %>
       <%= text_field_tag :search, params[:search], class: 'form-element' %>
-      <%= hidden_field_tag :sort, params[:sort]  %>
+      <%= hidden_field_tag :sort, params[:sort] || @sort_param  %>
     </div>
     <div class="actions has-padding-bottom-1">
       <button type="submit" class="button is-filled is-medium"><i class="fas fa-search"></i><span class="sr-only">Search</span></button>