Merge pull request #2011 from codidact/0valt/2010/array-search-params

Author: ArtOfCode-

app/helpers/search_helper.rb

@@ -114,11 +114,11 @@ def params_to_qualifiers(params)
       filter_qualifiers.append({ param: :source, value: params[:source].to_sym })
     end
 
-    if params[:include_tags]&.all? { |id| id.match? valid_value[:integer] }
+    if valid_tags_list?(params[:include_tags])
       filter_qualifiers.append({ param: :include_tags, tag_ids: params[:include_tags] })
     end
 
-    if params[:exclude_tags]&.all? { |id| id.match? valid_value[:integer] }
+    if valid_tags_list?(params[:exclude_tags])
       filter_qualifiers.append({ param: :exclude_tags, tag_ids: params[:exclude_tags] })
     end
 
@@ -244,6 +244,13 @@ def qualifiers_to_sql(qualifiers, query, user)
     query
   end
 
+  # Is a given param a valid list of tags?
+  # @param param [String, Array<String>, nil] parameter to check
+  # @return [Boolean] check result
+  def valid_tags_list?(param)
+    param.is_a?(Array) && param&.all? { |id| id.match?(/^\d+$/) }
+  end
+
   # Is a given param a valid source type?
   # @param param [String, Symbol, nil] parameter to check
   # @return [Boolean] check result

test/helpers/search_helper_test.rb

@@ -236,6 +236,16 @@ class SearchHelperTest < ActionView::TestCase
     assert_not(posts.any? { |p| p.category.id == admin_category.id })
   end
 
+  test 'valid_tags_list? should correctly determine if the param is valid' do
+    [[], ['42'], ['7', '747']].each do |valid|
+      assert valid_tags_list?(valid)
+    end
+
+    ['', '[\"42\"]', nil].each do |invalid|
+      assert_not valid_tags_list?(invalid)
+    end
+  end
+
   test 'valid_source_type? should correctly determine if the param is valid' do
     SearchHelper::SOURCE_TYPES.each do |type|
       assert valid_source_type?(type)