Rubocop & test

Author: ArtOfCode-

app/jobs/auto_close_complaints_job.rb

@@ -7,7 +7,7 @@ def perform(*_args)
     statuses = complaints.map do |complaint|
       complaint.update_status 'closed'
     end
-    successful = statuses.map { |x| x && 1 || 0 }.sum
+    successful = statuses.map { |x| (x && 1) || 0 }.sum
     logger.info "Found #{complaints.size} inactive complaints, successfully closed #{successful} of them."
   end
 end

app/jobs/clean_up_new_thread_followers_job.rb

@@ -15,13 +15,13 @@ def perform
       duplicate = followers.first
       result = duplicate.destroy
 
-      unless result
-        logger.warn "Failed to destroy new thread follower duplicate \"#{duplicate.id}\. Validations follow."
-        duplicate.errors.full_messages.each do |msg|
-          logger.warn msg
-        end
-        duplicate.errors.each { |e| puts e.full_message }
+      next if result
+
+      logger.warn "Failed to destroy new thread follower duplicate \"#{duplicate.id}. Validations follow."
+      duplicate.errors.full_messages.each do |msg|
+        logger.warn msg
       end
+      duplicate.errors.each { |e| puts e.full_message }
     end
 
     logger.info "Processed #{posts.size} posts."

app/jobs/clean_up_spammy_users_job.rb

@@ -18,13 +18,13 @@ def perform(created_after: 1.month.ago)
           flag.post_flag_type.name == "it's spam" && flag.status == 'helpful'
         end
       end
-      if all_posts_spam
-        blocked += 1
-        spammer.block('automatic block from spam cleanup job', length: 2.years)
-        spammer.soft_delete(User.system)
-      end
+      next unless all_posts_spam
+
+      blocked += 1
+      spammer.block('automatic block from spam cleanup job', length: 2.years)
+      spammer.soft_delete(User.system)
     end
 
-    logger.info "Considered #{possible_spammers.count} potential spammers, blocked #{blocked}."
+    logger.info "Considered #{possible_spammers.size} potential spammers, blocked #{blocked}."
   end
 end

app/jobs/clean_up_thread_followers_job.rb

@@ -15,13 +15,13 @@ def perform
       duplicate = followers.first
       result = duplicate.destroy
 
-      unless result
-        logger.warn "Failed to destroy thread follower duplicate \"#{duplicate.id}\. Validations follow."
-        duplicate.errors.full_messages.each do |msg|
-          logger.warn msg
-        end
-        duplicate.errors.each { |e| puts e.full_message }
+      next if result
+
+      logger.warn "Failed to destroy thread follower duplicate \"#{duplicate.id}. Validations follow."
+      duplicate.errors.full_messages.each do |msg|
+        logger.warn msg
       end
+      duplicate.errors.each { |e| puts e.full_message }
     end
 
     logger.info "Processed #{threads.size} threads."