fixed total post count regression when showing a user

Author: Oaphi

app/controllers/users_controller.rb

@@ -45,12 +45,13 @@ def index
 
   def show
     @abilities = Ability.on_user(@user)
+    @limit = params[:limit]&.to_i || 15
 
     @posts = set_posts.user_sort({ term: params[:sort], default: :score },
                                  age: :created_at, score: :score)
-                      .first(15)
 
     @total_post_count = @posts.count
+    @posts = @posts.first(@limit)
     render layout: 'without_sidebar'
   end
 

test/controllers/users_controller_test.rb

@@ -48,6 +48,20 @@ class UsersControllerTest < ActionController::TestCase
     assert_response(:not_found)
   end
 
+  test 'should correctly show user post count' do
+    std = users(:standard_user)
+    post_count = Post.all.by(std).count
+    limit = post_count - 1
+
+    assert post_count.positive? && limit.positive?
+
+    sign_in std
+    get :show, params: { id: std.id, limit: limit }
+
+    assert_equal assigns(:posts)&.count, limit
+    assert_equal assigns(:total_post_count), post_count
+  end
+
   test 'should get mod tools page' do
     sign_in users(:moderator)
     get :mod, params: { id: users(:standard_user).id }