moved user ping regular expression to a USER_PING_REG_EXP constant to avoid fragmentation

Author: Oaphi

app/controllers/comments_controller.rb

@@ -457,7 +457,7 @@ def check_if_target_post_locked
   # @return [Array<Integer>] list of pinged user ids
   def check_for_pings(thread, content)
     pingable = thread.pingable
-    matches = content.scan(/@#(\d+)/)
+    matches = content.scan(Comment::USER_PING_REG_EXP)
     matches.flatten.select { |m| pingable.include?(m.to_i) }.map(&:to_i)
   end
 

app/helpers/comments_helper.rb

@@ -37,7 +37,7 @@ def comment_user_link(comment)
   # @param content [String] content to get pinged users from
   # @return [Hash{String => User}] list of pinged users
   def pinged_users(content)
-    user_ids = content.scan(/@#(\d+)/).map { |g| g[0].to_i }
+    user_ids = content.scan(Comment::USER_PING_REG_EXP).map { |g| g[0].to_i }
     User.where(id: user_ids).to_a.to_h { |u| [u.id, u] }
   end
 
@@ -49,7 +49,7 @@ def pinged_users(content)
   def render_pings(content, pingable: nil, host: nil)
     users = pinged_users(content)
 
-    content.gsub(/@#(\d+)/) do |ping|
+    content.gsub(Comment::USER_PING_REG_EXP) do |ping|
       user = users[Regexp.last_match(1).to_i]
       if user.nil?
         ping
@@ -70,7 +70,7 @@ def render_pings(content, pingable: nil, host: nil)
   def render_pings_text(content)
     users = pinged_users(content)
 
-    content.gsub(/@#(\d+)/) do |ping|
+    content.gsub(Comment::USER_PING_REG_EXP) do |ping|
       user = users[Regexp.last_match(1).to_i]
       user.nil? ? ping : "@#{rtl_safe_username(user)}"
     end

app/models/comment.rb

@@ -4,6 +4,8 @@ class Comment < ApplicationRecord
   include SoftDeletable
   include Timestamped
 
+  USER_PING_REG_EXP = /@#(\d+)/
+
   scope :by, ->(user) { where(user: user) }
 
   belongs_to :user
@@ -41,7 +43,7 @@ def content_length
 
   def pings
     pingable = thread.pingable
-    matches = content.scan(/@#(\d+)/)
+    matches = content.scan(USER_PING_REG_EXP)
     matches.flatten.select { |m| pingable.include?(m.to_i) }.map(&:to_i)
   end