Skip to content

Commit 798664b

Browse files
committed
switched to symlinks for several of the Node.js related deps (NPM has issues with module resolution otherwise)
1 parent 9e834a9 commit 798664b

2 files changed

Lines changed: 14 additions & 10 deletions

File tree

docker/Dockerfile

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -22,18 +22,20 @@ RUN bundle install
2222

2323
# cherry pick only what we really need to run Node.js
2424
COPY --from=node /usr/local/bin/node /usr/local/bin
25-
COPY --from=node /usr/local/bin/nodejs /usr/local/bin
26-
COPY --from=node /usr/local/bin/npm /usr/local/bin
27-
COPY --from=node /usr/local/bin/npx /usr/local/bin
28-
COPY --from=node /usr/local/bin/yarn /usr/local/bin
29-
COPY --from=node /usr/local/bin/yarnpkg /usr/local/bin
3025
COPY --from=node /usr/local/include/node /usr/local/include
3126
COPY --from=node /usr/local/lib/node_modules /usr/local/lib/node_modules
3227
COPY --from=node /usr/local/share/doc/node /usr/local/share/doc
3328
COPY --from=node /usr/local/share/man/man1/node.1 /usr/local/share/man/man1
3429
COPY --from=node /usr/local/share/systemtap/tapset/node.stp /usr/local/share/systemtap/tapset
3530
COPY --from=node /opt/yarn-v1.22.4 /opt/yarn-v1.22.4
3631

32+
# create symlinks needed to run Node.js & NPM
33+
RUN ln -s /usr/local/lib/node_modules/npm/bin/npm-cli.js /usr/local/bin/npm
34+
RUN ln -s /usr/local/lib/node_modules/npm/bin/npx-cli.js /usr/local/bin/npx
35+
RUN ln -s /opt/yarn-v1.22.4/bin/yarn /usr/local/bin/yarn
36+
RUN ln -s /opt/yarn-v1.22.4/bin/yarnpkg /usr/local/bin/yarnpkg
37+
RUN ln -s /usr/local/bin/node /usr/local/bin/nodejs
38+
3739
FROM build
3840

3941
# setup a dedicated user for Node.js

docker/Dockerfile.dev

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,18 +23,20 @@ RUN bundle install
2323

2424
# cherry pick only what we really need to run Node.js
2525
COPY --from=node /usr/local/bin/node /usr/local/bin
26-
COPY --from=node /usr/local/bin/nodejs /usr/local/bin
27-
COPY --from=node /usr/local/bin/npm /usr/local/bin
28-
COPY --from=node /usr/local/bin/npx /usr/local/bin
29-
COPY --from=node /usr/local/bin/yarn /usr/local/bin
30-
COPY --from=node /usr/local/bin/yarnpkg /usr/local/bin
3126
COPY --from=node /usr/local/include/node /usr/local/include
3227
COPY --from=node /usr/local/lib/node_modules /usr/local/lib/node_modules
3328
COPY --from=node /usr/local/share/doc/node /usr/local/share/doc
3429
COPY --from=node /usr/local/share/man/man1/node.1 /usr/local/share/man/man1
3530
COPY --from=node /usr/local/share/systemtap/tapset/node.stp /usr/local/share/systemtap/tapset
3631
COPY --from=node /opt/yarn-v1.22.4 /opt/yarn-v1.22.4
3732

33+
# create symlinks needed to run Node.js & NPM
34+
RUN ln -s /usr/local/lib/node_modules/npm/bin/npm-cli.js /usr/local/bin/npm
35+
RUN ln -s /usr/local/lib/node_modules/npm/bin/npx-cli.js /usr/local/bin/npx
36+
RUN ln -s /opt/yarn-v1.22.4/bin/yarn /usr/local/bin/yarn
37+
RUN ln -s /opt/yarn-v1.22.4/bin/yarnpkg /usr/local/bin/yarnpkg
38+
RUN ln -s /usr/local/bin/node /usr/local/bin/nodejs
39+
3840
FROM build
3941

4042
# setup a dedicated user for Node.js

0 commit comments

Comments
 (0)