added test for thread_rename preventing same-title updates

Author: Oaphi

test/controllers/comments/rename_test.rb

@@ -9,11 +9,12 @@ class CommentsControllerTest < ActionController::TestCase
     sign_in users(:deleter)
 
     try_rename_thread(comment_threads(:normal))
+    @thread = assigns(:comment_thread)
 
     assert_response(:found)
-    assert_not_nil assigns(:comment_thread)
-    assert_redirected_to comment_thread_path(assigns(:comment_thread))
-    assert_equal 'new thread title', assigns(:comment_thread).title
+    assert_not_nil(@thread)
+    assert_redirected_to comment_thread_path(@thread)
+    assert_equal 'new thread title', @thread.title
   end
 
   test 'non-moderators should not be able to rename restricted threads' do
@@ -26,12 +27,26 @@ class CommentsControllerTest < ActionController::TestCase
       @thread = assigns(:comment_thread)
 
       assert_response(:found)
-      assert_not_nil @thread
+      assert_not_nil(@thread)
       assert_redirected_to comment_thread_path(@thread)
       assert_equal before_title, @thread.title
     end
   end
 
+  test 'should not allow renaming to the current title' do
+    sign_in users(:admin)
+
+    thread = comment_threads(:normal)
+
+    try_rename_thread(thread, title: thread.title)
+    @thread = assigns(:comment_thread)
+
+    assert_response(:found)
+    assert_not_nil(@thread)
+    assert_equal flash[:danger], I18n.t('comments.errors.no_rename_thread_to_current_title')
+    assert_equal thread.title, @thread.title
+  end
+
   test 'should correctly handle invalid thread titles' do
     sign_in users(:admin)
 
@@ -40,7 +55,7 @@ class CommentsControllerTest < ActionController::TestCase
       @thread = assigns(:comment_thread)
 
       assert_response(:found)
-      assert_not_nil @thread
+      assert_not_nil(@thread)
       assert_not @thread.valid?
       assert_not_nil flash[:danger]
     end