Merge pull request #1996 from codidact/art/job-logs

Author: ArtOfCode-

app/jobs/application_job.rb

@@ -1,7 +1,16 @@
 class ApplicationJob < ActiveJob::Base
   # Automatically retry jobs that encountered a deadlock
-  # retry_on ActiveRecord::Deadlocked
+  retry_on ActiveRecord::Deadlocked
 
   # Most jobs are safe to ignore if the underlying records are no longer available
-  # discard_on ActiveJob::DeserializationError
+  discard_on ActiveJob::DeserializationError
+
+  def initialize
+    @job_id = SecureRandom.uuid
+    super
+  end
+
+  def logger
+    Rails.job_logger.tagged(self.class.name, @job_id)
+  end
 end

app/jobs/auto_close_complaints_job.rb

@@ -4,8 +4,10 @@ class AutoCloseComplaintsJob < ApplicationJob
   def perform(*_args)
     complaints = Complaint.where(status: 'reviewed')
                           .where(Arel.sql('status_updated_at <= ?', 14.days.ago))
-    complaints.each do |complaint|
+    statuses = complaints.map do |complaint|
       complaint.update_status 'closed'
     end
+    successful = statuses.compact_blank.size
+    logger.info "Found #{complaints.size} inactive complaints, successfully closed #{successful} of them."
   end
 end

app/jobs/clean_up_new_thread_followers_job.rb

@@ -15,10 +15,14 @@ def perform
       duplicate = followers.first
       result = duplicate.destroy
 
-      unless result
-        puts "failed to destroy new thread follower duplicate \"#{duplicate.id}\""
-        duplicate.errors.each { |e| puts e.full_message }
+      next if result
+
+      logger.warn "Failed to destroy new thread follower duplicate \"#{duplicate.id}. Validations follow."
+      duplicate.errors.full_messages.each do |msg|
+        logger.warn msg
       end
     end
+
+    logger.info "Processed #{posts.size} posts."
   end
 end

app/jobs/clean_up_spammy_users_job.rb

@@ -9,17 +9,22 @@ def perform(created_after: 1.month.ago)
                             .where(users: { deleted: false }).group('users.id').having('count(posts.id) > 0')
                             .having('count(distinct if(posts.deleted = true, null, posts.id)) = 0')
 
+    blocked = 0
+
     possible_spammers.each do |spammer|
       all_posts_spam = spammer.posts.all? do |post|
         # A post is considered spam if there are any helpful spam flags on it.
         post.flags.any? do |flag|
           flag.post_flag_type.name == "it's spam" && flag.status == 'helpful'
         end
       end
-      if all_posts_spam
-        spammer.block('automatic block from spam cleanup job', length: 2.years)
-        spammer.soft_delete(User.system)
-      end
+      next unless all_posts_spam
+
+      blocked += 1
+      spammer.block('automatic block from spam cleanup job', length: 2.years)
+      spammer.soft_delete(User.system)
     end
+
+    logger.info "Considered #{possible_spammers.size} potential spammers, blocked #{blocked}."
   end
 end

app/jobs/clean_up_thread_followers_job.rb

@@ -15,10 +15,14 @@ def perform
       duplicate = followers.first
       result = duplicate.destroy
 
-      unless result
-        puts "failed to destroy thread follower duplicate \"#{duplicate.id}\""
-        duplicate.errors.each { |e| puts e.full_message }
+      next if result
+
+      logger.warn "Failed to destroy thread follower duplicate \"#{duplicate.id}. Validations follow."
+      duplicate.errors.full_messages.each do |msg|
+        logger.warn msg
       end
     end
+
+    logger.info "Processed #{threads.size} threads."
   end
 end

app/jobs/cleanup_votes_job.rb

@@ -3,28 +3,32 @@ class CleanupVotesJob < ApplicationJob
 
   def perform
     Community.all.each do |c|
-      RequestContext.community = c
-      orphan_votes = Vote.all.reject { |v| v.post.present? }
+      logger.tagged(c.name) do
+        RequestContext.community = c
+        orphan_votes = Vote.all.reject { |v| v.post.present? }
 
-      puts "[#{c.name}] destroying #{orphan_votes.length} #{'orphan vote'.pluralize(orphan_votes.length)}"
+        logger.info "Removing #{orphan_votes.length} #{'orphan vote'.pluralize(orphan_votes.length)}"
 
-      system_user = User.find(-1)
+        system_user = User.find(-1)
 
-      orphan_votes.each do |v|
-        result = v.destroy
+        orphan_votes.each do |v|
+          result = v.destroy
 
-        if result
-          AuditLog.admin_audit(
-            comment: "Deleted orphaned vote for user ##{v.recv_user_id} " \
-                     "on post ##{v.post_id} " \
-                     "in community ##{c.id} (#{c.name})",
-            event_type: 'vote_delete',
-            related: v,
-            user: system_user
-          )
-        else
-          puts "[#{c.name}] failed to destroy vote \"#{v.id}\""
-          v.errors.each { |e| puts e.full_message }
+          if result
+            AuditLog.admin_audit(
+              comment: "Deleted orphaned vote for user ##{v.recv_user_id} " \
+                       "on post ##{v.post_id} " \
+                       "in community ##{c.id} (#{c.name})",
+              event_type: 'vote_delete',
+              related: v,
+              user: system_user
+            )
+          else
+            logger.warn "Failed to remove vote #{v.id}. Validations follow."
+            v.errors.full_messages.each do |msg|
+              logger.warn msg
+            end
+          end
         end
       end
     end

app/jobs/potential_spam_profiles_job.rb

@@ -14,5 +14,7 @@ def perform
       UserAbility.where(community_user_id: cu_ids, ability_id: ability_ids)
                  .update_all(is_suspended: true, suspension_message: 'This ability has been automatically suspended.')
     end
+
+    logger.info "Found #{users.size} likely spam profiles & suspended abilities."
   end
 end

app/jobs/send_summary_emails_job.rb

@@ -15,5 +15,7 @@ def perform
                    .content_summary
                    .deliver_later
     end
+
+    logger.info "Scheduled send of #{staff.size} emails."
   end
 end

config/initializers/job_logger.rb

@@ -0,0 +1,16 @@
+module Rails
+  class << self
+    @job_logger = nil
+
+    def job_logger
+      if @job_logger.nil?
+        logger = ActiveSupport::Logger.new(Rails.root.join('log/jobs.log'))
+        logger.level = Rails.configuration.log_level
+        logger.formatter = ::Logger::Formatter.new
+        @job_logger = ActiveSupport::TaggedLogging.new(logger)
+      else
+        @job_logger
+      end
+    end
+  end
+end