added a shared _notices partial (DRY)

Author: Oaphi

app/views/layouts/application.html.erb

@@ -12,13 +12,7 @@
       <div class="grid">
         <div class="grid--cell is-8-lg is-12">
           <div class="has-padding-4">
-            <% {notice: :info, alert: :danger, danger: :danger, success: :success, info: :info, warning: :warning}.each do |mt, cc| %>
-              <% if flash[mt].present? %>
-                <div class="notice is-<%= cc.to_s %>">
-                  <%= flash[mt] %>
-                </div>
-              <% end %>
-            <% end %>
+            <%= render 'shared/notices' %>
 
             <% if @first_visit_notice %>
               <% notice = SiteSetting['FirstVisitGuidance'] %>

app/views/layouts/stripe.html.erb

@@ -14,14 +14,7 @@
   <div class="grid">
     <div class="grid--cell is-12">
       <div class="has-padding-4">
-        <% {notice: :info, alert: :danger, danger: :danger, success: :success, info: :info, warning: :warning}.each do |mt, cc| %>
-          <% if flash[mt].present? %>
-            <div class="notice is-<%= cc.to_s %>">
-              <%= flash[mt] %>
-            </div>
-          <% end %>
-        <% end %>
-
+        <%= render 'shared/notices' %>
 
         <% if @first_visit_notice %>
           <% notice = SiteSetting['FirstVisitGuidance'] %>

app/views/layouts/without_sidebar.html.erb

@@ -10,13 +10,7 @@
       <div class="grid">
         <div class="grid--cell is-12">
           <div class="has-padding-4">
-            <% {notice: :info, alert: :danger, danger: :danger, success: :success, info: :info, warning: :warning}.each do |mt, cc| %>
-              <% if flash[mt].present? %>
-                <div class="notice is-<%= cc.to_s %>">
-                  <%= flash[mt] %>
-                </div>
-              <% end %>
-            <% end %>
+            <%= render 'shared/notices' %>
 
             <% if @first_visit_notice %>
               <% notice = SiteSetting['FirstVisitGuidance'] %>

app/views/shared/_notices.html.erb

@@ -0,0 +1,12 @@
+<% { notice: :info,
+     alert: :danger,
+     danger: :danger,
+     success: :success,
+     info: :info,
+     warning: :warning }.each do |type, content| %>
+  <% if flash[type].present? %>
+    <div class="notice is-<%= content.to_s %>">
+      <%= flash[type] %>
+    </div>
+  <% end %>
+<% end %>