Merge pull request #1943 from codidact/0valt/1891/post-500-fix

Author: ArtOfCode-

app/controllers/posts_controller.rb

@@ -36,15 +36,23 @@ def new
   end
 
   def create
+    submitted = params[:post]
+
+    unless submitted.present?
+      flash[:danger] = helpers.i18ns('posts.create_requires_post')
+      redirect_back fallback_location: root_path
+      return
+    end
+
     @parent = Post.where(id: params[:parent]).first
     @post_type = if @parent.present? && @parent.post_type.answer_type.present?
                    @parent.post_type.answer_type
                  else
-                   PostType.find(params[:post][:post_type_id])
+                   PostType.find(submitted[:post_type_id])
                  end
     @category = if @post_type.has_category
-                  if params[:post][:category_id].present?
-                    Category.find(params[:post][:category_id])
+                  if submitted[:category_id].present?
+                    Category.find(submitted[:category_id])
                   elsif @parent.present?
                     @parent.category
                   end

config/locales/strings/en.posts.yml

@@ -1,6 +1,8 @@
 en:
   posts:
     #alert/notice
+    create_requires_post: >
+      Can't create a post without content. Please try again later or contact us.
     category_low_trust_level: >
       You don't have a high enough trust level to post in the :name category.
     type_requires_category: >

test/controllers/posts/create_test.rb

@@ -31,6 +31,20 @@ class PostsControllerTest < ActionController::TestCase
     assert_redirected_to_sign_in
   end
 
+  test 'create requires post' do
+    sign_in users(:standard_user)
+
+    post :create, params: {
+      category: categories(:main).id,
+      post_type: post_types(:question).id
+    }
+
+    assert_response(:found)
+    assert_redirected_to root_path
+    assert_not_nil flash[:danger]
+    assert_nil assigns(:post)
+  end
+
   test 'can create help post' do
     sign_in users(:moderator)