Merge pull request #1826 from codidact/0valt/keyboard

Keyboard event-related fixes + notifications improvements

Author: Oaphi

app/assets/javascripts/character_count.js

@@ -91,6 +91,7 @@ $(() => {
     } else if (gteThreshold) {
       setCounterState($counter, 'warning');
       setCounterIcon($icon, 'fa-exclamation-circle');
+      setInputValidationState($tgt, 'valid');
     } else {
       setCounterState($counter, 'default');
       setCounterIcon($icon, 'fa-check');

app/assets/javascripts/comments.js

@@ -41,24 +41,24 @@ $(() => {
     window.hljs && hljs.highlightAll();
   }
 
-  $(document).on('click', '.post--comments-thread.is-inline a', async (evt) => {
-    if (evt.ctrlKey) {
-      return; // TODO: do we need this early exit?
+  $(document).on('click', '.post--comments-thread.is-inline a', async (ev) => {
+    if (ev.ctrlKey || ev.metaKey) {
+      return;
     }
 
-    evt.preventDefault();
+    ev.preventDefault();
 
-    const $tgt = $(evt.target);
+    const $tgt = $(ev.target);
     const $threadId = $tgt.data('thread');
     const wrapper = getCommentThreadWrapper($tgt);
 
     openThread(wrapper, $threadId);
   });
 
   $(document).on('click', '.js-show-deleted-comments', (ev) => {
-    if (ev.ctrlKey) {
+    if (ev.ctrlKey || ev.metaKey) {
       return;
-    } // do we really need it?
+    }
 
     ev.preventDefault();