added Flag#accessible_to class method & tests

Author: Oaphi

app/models/flag.rb

@@ -23,6 +23,20 @@ class Flag < ApplicationRecord
 
   validate :maximum_reason_length
 
+  # Gets flags appropriately scoped for a given user & post
+  # @param user [User, nil] user to check
+  # @param post [Post] post to check
+  # @return [ActiveRecord::Relation<Flag>]
+  def self.accessible_to(user, post)
+    if user&.at_least_moderator?
+      post.flags
+    elsif user&.can_handle_flags?
+      post.flags.not_confidential
+    else
+      post.flags.none
+    end
+  end
+
   # Checks if the flag is confidential as per its type
   # @return [Boolean] check result
   def confidential?

test/fixtures/flags.yml

@@ -1,12 +1,14 @@
 one:
   reason: ABCDEF GHIJKL MNOPQR STUVWX YZ
   post: answer_two (Post)
+  post_flag_type: not_confidential
   user: standard_user
   community: sample
 
 declined:
   reason: Please decline it
   post: question_one (Post)
+  post_flag_type: not_confidential
   user: standard_user
   community: sample
   status: declined

test/models/flag_test.rb

@@ -30,4 +30,18 @@ class FlagTest < ActiveSupport::TestCase
     valid = Flag.new(reason: 'my reasons are my own', **common_attributes)
     assert valid.valid?
   end
+
+  test 'accessible_to should correctly scope flags' do
+    std = users(:standard_user)
+    del = users(:deleter)
+    mod = users(:moderator)
+
+    [std, del, mod].each do |user|
+      flags = Flag.accessible_to(user, posts(:question_one))
+      assert_equal user.same_as?(std), flags.none?
+    end
+
+    assert Flag.accessible_to(mod, posts(:deleted)).any?(&:confidential?)
+    assert_not Flag.accessible_to(del, posts(:deleted)).any?(&:confidential?)
+  end
 end