Merge pull request #2015 from codidact/0valt/2009/tag-sorting

Author: ArtOfCode-

app/models/tag.rb

@@ -49,7 +49,7 @@ def self.search(term)
 
     # Select from the union of the above queries, select only the tag columns such that we can distinct them
     from(Arel.sql("((#{q1.to_sql}) UNION (#{q2.to_sql})) tags"))
-      .order(Arel.sql(sanitize_sql_array(['name LIKE ? DESC, name', value])))
+      .order(Arel.sql(sanitize_sql_array(['name LIKE ? DESC, char_length(name), name', value])))
       .select(Tag.column_names.map { |c| "tags.#{c}" })
       .distinct
   end

test/models/tag_test.rb

@@ -12,7 +12,7 @@ class TagTest < ActiveSupport::TestCase
 
     tags = Tag.search(term).to_a
 
-    name_match_sorted = tags.select { |t| t.name.include?(term) }.sort { |a, b| a.name <=> b.name }
+    name_match_sorted = tags.select { |t| t.name.include?(term) }.sort { |a, b| a.name.length <=> b.name.length }
     excerpt_match_sorted = tags.select { |t| t.excerpt&.include?(term) }.sort { |a, b| a.name <=> b.name }
     sorted_tags = name_match_sorted + excerpt_match_sorted