Skip to content

Commit d11d22f

Browse files
authored
Merge pull request #1721 from codidact/0valt/comments
Enable username autocomplete in thread titles
2 parents 40d00c2 + 15942f1 commit d11d22f

3 files changed

Lines changed: 10 additions & 3 deletions

File tree

app/assets/javascripts/comments.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -236,7 +236,7 @@ $(() => {
236236
* @type {Record<`${number}-${number}`, Record<string, number>>}
237237
*/
238238
const pingable = {};
239-
$(document).on('keyup', '.js-comment-field', pingable_popup);
239+
$(document).on('keyup', '.js-comment-field, .js-thread-title-field', pingable_popup);
240240

241241
/**
242242
* @type {QPixelPingablePopupCallback}

app/views/comments/_new_thread_modal.html.erb

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,11 @@
3939
You can give your comment thread a title. If you leave this blank, the beginning of the initial comment will
4040
be shown.
4141
</span>
42-
<%= text_field_tag :title, '', class: 'form-element', data: { character_count: ".js-character-count-thread-title" } %>
42+
<%= text_field_tag :title, '',
43+
class: 'form-element js-thread-title-field',
44+
data: { post: post.id,
45+
thread: '-1',
46+
character_count: ".js-character-count-thread-title" } %>
4347
<%= render 'shared/char_count', type: 'thread-title' %>
4448

4549
<%= submit_tag 'Create thread', class: 'button is-filled', id: "create_thread_button_#{post.id}", disabled: true %>

app/views/comments/_rename_thread_modal.html.erb

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,10 @@
1616
</div>
1717
<div class="modal--body">
1818
<%= label_tag :title, 'Title', class: 'form-element' %>
19-
<%= text_field_tag :title, thread.title, class: 'form-element' %>
19+
<%= text_field_tag :title,
20+
thread.title,
21+
class: 'form-element js-thread-title-field',
22+
data: { post: thread.post.id, thread: thread.id } %>
2023
</div>
2124
<div class="modal--footer">
2225
<%= submit_tag 'Update thread', class: 'button is-muted is-filled' %>

0 commit comments

Comments
 (0)