trying to create an invalid pinned link should be a 400 status response

Author: Oaphi

app/controllers/pinned_links_controller.rb

@@ -41,7 +41,7 @@ def create
         'Your pinned link has been created. Due to caching, it may take some time until it is shown.'
       redirect_to pinned_links_path
     else
-      render 'pinned_links/new'
+      render 'pinned_links/new', status: :bad_request
     end
   end
 

test/controllers/pinned_links_controller_test.rb

@@ -43,6 +43,13 @@ class PinnedLinksControllerTest < ActionController::TestCase
     assert_not_nil assigns(:link)
   end
 
+  test 'create should correctly handle invalid pinned links' do
+    sign_in users(:moderator)
+    try_create_pinned_link
+    assert_response(:bad_request)
+    assert assigns(:link)&.errors&.any?
+  end
+
   test 'update should correctly update pinned links' do
     sign_in users(:moderator)