Skip to content

Commit d542bfd

Browse files
authored
Merge pull request #1800 from codidact/0valt/1799/thread-title-min
Remove min length attr from the new thread title field
2 parents 2411717 + 9acdd22 commit d542bfd

10 files changed

Lines changed: 35 additions & 36 deletions

app/views/comments/_new_thread.html.erb

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
<%#
2-
Renders new comment thread button & modal
2+
"Renders new comment thread button & modal
33
4-
Variables:
5-
post : post to create a new thread for
6-
text : text to display on the button
7-
user : user that will create a new thread
8-
%>
4+
Variables:
5+
post : post to create a new thread for
6+
text : text to display on the button
7+
user : user that will create a new thread
8+
"%>
99

1010
<%
1111
can_comment = user.can_comment_on?(post)

app/views/comments/_new_thread_modal.html.erb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@
4747
markdown: 'strip' } %>
4848
<%= render 'shared/char_count',
4949
type: "thread-title-#{post.id}",
50-
min: 1,
5150
max: maximum_thread_title_length %>
5251

5352
<%= submit_tag 'Create thread',

app/views/comments/_rename_thread_modal.html.erb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
<%#
22
"Helper for rendering comment thread rename action modal
33
4-
Variables:
5-
thread : Comment thread to create the modal for
4+
Variables:
5+
thread : Comment thread to create the modal for
66
"%>
77

88
<div class="modal is-with-backdrop is-small js--rename-thread-<%= thread.id %>">

app/views/comments/_reply_to_thread.html.erb

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
<%#
2-
Renders reply to comment thread button & input
2+
"Renders reply to comment thread button & input
33
4-
Variables:
5-
inline : whether the reply is done via inline thread view
6-
post : post the thread is for
7-
text : text to display on the button
8-
thread : thread to create a reply for
9-
user : user that will create a reply to the thread
10-
%>
4+
Variables:
5+
inline : whether the reply is done via inline thread view
6+
post : post the thread is for
7+
text : text to display on the button
8+
thread : thread to create a reply for
9+
user : user that will create a reply to the thread
10+
"%>
1111

1212
<%
1313
# TODO: make configurable

app/views/comments/_skip_deleted.erb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
<%#
2-
Renders widgets indicating that deleted comments are not shown
2+
"Renders widgets indicating that deleted comments are not shown
33
44
Variables:
55
num_skipped : number of skipped deleted comments
66
inline : whether the thread is shown inline or not
77
thread : CommentThread to display the widget for
8-
%>
8+
"%>
99

1010
<div class="widget--body widget--deleted-comments" role="listitem">
1111
<p>

app/views/comments/_thread_follow_link.html.erb

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
<%#
2-
Helper for rendering comment thread follow/unfollow link buttons
2+
"Helper for rendering comment thread follow/unfollow link buttons
33
4-
Variables:
5-
thread : Comment thread to create the link for
6-
user : user to show the link for
7-
%>
4+
Variables:
5+
thread : Comment thread to create the link for
6+
user : user to show the link for
7+
"%>
88

99
<% if thread.followed_by?(user) %>
1010
<a href="#"

app/views/comments/_thread_followers_modal.html.erb

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
<%#
2-
Helper for rendering comment thread followers action modal
2+
"Helper for rendering comment thread followers action modal
33
4-
Variables:
5-
thread : Comment thread to create the modal for
6-
%>
4+
Variables:
5+
thread : Comment thread to create the modal for
6+
"%>
77

88
<div class="modal is-with-backdrop is-small" id="js-followers-<%= thread.id %>">
99
<div class="modal--container">

app/views/comments/_thread_tools_link.html.erb

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
<%#
2-
Helper for rendering comment thread tools link buttons
2+
"Helper for rendering comment thread tools link buttons
33
4-
Variables:
5-
thread : Comment thread to create the link for
6-
%>
4+
Variables:
5+
thread : Comment thread to create the link for
6+
"%>
77

88
<a href="javascript:void(0)"
99
class="widget--header-link"

app/views/comments/_threads_list.html.erb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
<%#
2-
List of comment threads below a post.
2+
"List of comment threads below a post.
33
44
Variables:
55
comment_threads : an Array of CommentThread instances to list
66
? comment_id : Comment to show even if it would be hidden otherwise
77
? thread_id : CommentThread ID to render expanded view for
88
? show_deleted : whether to display deleted comments in the expanded view
9-
%>
9+
"%>
1010

1111
<%
1212
comment_id ||= defined?(comment_id) ? comment_id : nil

app/views/comments/thread.html.erb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<%#
2-
Comment thread view.
2+
"Comment thread view.
33
44
Parameters:
55
params[:inline] : whether the parent thread is displayed inline
@@ -8,7 +8,7 @@
88
Instance variables:
99
@comment_thread : CommentThread to display
1010
@post : Post the thread belongs to
11-
%>
11+
"%>
1212

1313
<h1>Comments on
1414
<a href="<%= generic_share_link(@post) %>"><%= @post.title.blank? && @post.parent.present? ? @post.parent.title : @post.title %></a>

0 commit comments

Comments
 (0)