Merge pull request #1830 from codidact/0valt/caching

Further caching improvement

Author: Oaphi

app/models/comment.rb

@@ -19,6 +19,12 @@ class Comment < ApplicationRecord
 
   validate :content_length
 
+  # Gets last activity date and time on the comment
+  # @return [DateTime] last activity date and time
+  def last_activity_at
+    [created_at, updated_at].compact.max
+  end
+
   def root
     # If parent_question is nil, the comment is already on a question, so we can just return post.
     parent_question || post

app/models/comment_thread.rb

@@ -52,7 +52,8 @@ def can_access?(user)
   # Gets last activity date and time on the thread
   # @return [DateTime] last activity date and time
   def last_activity_at
-    [created_at, locked_at, updated_at].compact.max
+    last_comment_activity_at = comments.map(&:last_activity_at).max
+    [created_at, locked_at, updated_at, last_comment_activity_at].compact.max
   end
 
   # Gets a list of user IDs who should be pingable in the thread.

test/fixtures/comments.yml

@@ -4,13 +4,17 @@ one:
   content: ABCDEF GHIJKL MNOPQR
   community: sample
   comment_thread: normal
+  created_at: 2020-01-01T00:00:00.000000Z
+  updated_at: 2021-01-01T00:00:00.000000Z
 
 two:
   user: standard_user
   post: question_two
   content: ABCDEF GHIJKL MNOPQR
   community: sample
   comment_thread: normal_two
+  created_at: 2020-01-01T00:00:00.000000Z
+  updated_at: 2021-01-01T00:00:00.000000Z
 
 deleted:
   user: standard_user
@@ -19,38 +23,50 @@ deleted:
   deleted: true
   community: sample
   comment_thread: normal
+  created_at: 2020-01-01T00:00:00.000000Z
+  updated_at: 2021-01-01T00:00:00.000000Z
 
 deleted_thread:
   user: standard_user
   post: question_one
   content: ABCDEF GHIJKL MNOPQR
   community: sample
   comment_thread: deleted
+  created_at: 2020-01-01T00:00:00.000000Z
+  updated_at: 2021-01-01T00:00:00.000000Z
 
 locked_thread:
   user: standard_user
   post: question_one
   content: ABCDEF GHIJKL MNOPQR
   community: sample
   comment_thread: locked
+  created_at: 2020-01-01T00:00:00.000000Z
+  updated_at: 2021-01-01T00:00:00.000000Z
 
 archived_thread:
   user: standard_user
   post: question_one
   content: ABCDEF GHIJKL MNOPQR
   community: sample
   comment_thread: archived
+  created_at: 2020-01-01T00:00:00.000000Z
+  updated_at: 2021-01-01T00:00:00.000000Z
 
 on_answer:
   user: standard_user
   post: answer_one
   content: ABCDEF GHIJKL MNOPQR
   community: sample
   comment_thread: on_answer
+  created_at: 2020-01-01T00:00:00.000000Z
+  updated_at: 2021-01-01T00:00:00.000000Z
 
 new_user_on_own_post:
   user: basic_user
   post: new_user_question
   content: ABCDEF GHIJKL MNOPQR
   community: sample
   comment_thread: new_user_on_own_post
+  created_at: 2020-01-01T00:00:00.000000Z
+  updated_at: 2021-01-01T00:00:00.000000Z