Add creation of complaints

Author: ArtOfCode-

app/controllers/complaints_controller.rb

@@ -6,8 +6,36 @@ def index
   def report
     @report_types = AppConfig.safety_center['report_types'].select { |_k, t| t['enabled'] }
     @content_types = AppConfig.safety_center['content_types']
+    @complaint = Complaint.new
+    @errors = []
     render layout: 'without_sidebar'
   end
 
-  def create; end
+  def create
+    @report_types = AppConfig.safety_center['report_types'].select { |_k, t| t['enabled'] }
+    @content_types = AppConfig.safety_center['content_types']
+
+    complaint_params = params.permit(:report_type, :reported_url, :content_type, :user_wants_updates)
+    comment_params = params.permit(:content)
+    if user_signed_in?
+      complaint_params.merge!(user: current_user, email: current_user.email)
+      comment_params.merge!(user: current_user)
+    else
+      complaint_params.merge!(email: params[:email])
+    end
+
+    @complaint = Complaint.new(complaint_params)
+    if @complaint.save
+      @comment = ComplaintComment.new(comment_params.merge(complaint: @complaint, internal: false))
+      if @comment.save
+        redirect_to safety_center_path # report path
+      else
+        @errors = @comment.errors.full_messages + @complaint.errors.full_messages
+        render :report, status: :bad_request, layout: 'without_sidebar'
+      end
+    else
+      @errors = @complaint.errors.full_messages
+      render :report, status: :bad_request, layout: 'without_sidebar'
+    end
+  end
 end

app/models/complaint.rb

@@ -4,6 +4,10 @@ class Complaint < ApplicationRecord
 
   after_create :generate_access_token
 
+  validates :email, presence: -> { !user.present? }
+  validates :report_type, presence: true
+  validates :reported_url, presence: true
+
   private
 
   def generate_access_token

app/views/complaints/report.html.erb

@@ -17,13 +17,25 @@
   </p>
 </div>
 
+<% if @errors.any? %>
+  <div class="notice is-danger is-filled">
+    <p>Your report could not be saved because:</p>
+    <ul>
+      <% @errors.each do |msg| %>
+        <li><%= msg %></li>
+      <% end %>
+    </ul>
+  </div>
+<% end %>
+
 <div class="widget">
   <%= form_tag create_complaint_path, class: 'widget--body complaint-form' do %>
     <div class="form-group">
       <%= label_tag :report_type, 'What are you reporting?' %>
       <% @report_types.each do |key, type| %>
         <div class="form-radio-group">
-          <%= radio_button_tag :report_type, key, id: "report_type_#{key}", class: 'form-radio-element' %>
+          <%= radio_button_tag :report_type, key, id: "report_type_#{key}", class: 'form-radio-element',
+                               required: true %>
           <%= label_tag "report_type_#{key}", type['description'] %>
         </div>
       <% end %>
@@ -35,7 +47,7 @@
         Enter a URL or link to where we can find this content on our network. You can use the Copy Link button under
         posts to get a direct link to a post.
       </div>
-      <%= text_field_tag :reported_url, nil, class: 'form-element' %>
+      <%= text_field_tag :reported_url, nil, class: 'form-element', required: true %>
     </div>
 
     <div class="form-group hidden js-content-type" data-report-type="illegal">
@@ -63,7 +75,7 @@
     </div>
 
     <div class="form-group">
-      <%= label_tag :comment, 'Tell us more' %>
+      <%= label_tag :content, 'Tell us more' %>
       <div class="form-caption" data-report-type="none">
         Tell us any additional information you have about this report.
       </div>
@@ -83,18 +95,18 @@
         Tell us any additional information you have about this report. Is there any additional content we removed that
         you would like to include? Provide detailed reasoning explaining why you disagree with our classification.
       </div>
-      <%= text_area_tag :comment, nil, class: 'form-element', rows: 10 %>
+      <%= text_area_tag :content, nil, class: 'form-element', required: true, rows: 10 %>
     </div>
 
     <div class="form-group">
-      <%= label_tag :user_email, 'Your email address' %>
+      <%= label_tag :email, 'Your email address' %>
       <div class="form-caption">
         This is used for abuse prevention purposes, and to contact you if we need additional information or to update
         you on the status of your report. If you do not wish to receive further updates about your report, please
         opt out below.
       </div>
-      <%= text_field_tag :user_email, user_signed_in? ? current_user.email : nil, class: 'form-element',
-                         disabled: user_signed_in? %>
+      <%= text_field_tag :email, user_signed_in? ? current_user.email : nil, class: 'form-element',
+                         disabled: user_signed_in?, required: true %>
     </div>
 
     <div class="form-group">

config/locales/en.yml

@@ -1,23 +1,16 @@
-# Files in the config/locales directory are used for internationalization
-# and are automatically loaded by Rails. If you want to use locales other
-# than English, add the necessary files in this directory.
-#
-# To use the locales, use `I18n.t`:
-#
-#     I18n.t 'hello'
-#
-# In views, this is aliased to just `t`:
-#
-#     <%= t('hello') %>
-#
-# To use a different locale, set it with `I18n.locale`:
-#
-#     I18n.locale = :es
-#
-# This would use the information in config/locales/es.yml.
-#
-# To learn more, please read the Rails Internationalization guide
-# available at http://guides.rubyonrails.org/i18n.html.
-
 en:
-  hello: "Hello world"
+  activerecord:
+    attributes:
+      complaint:
+        email: 'Your email address'
+        reported_url: 'Reported URL'
+    errors:
+      models:
+        complaint:
+          attributes:
+            email:
+              blank: 'is required'
+            reported_url:
+              blank: 'is required (please answer "Where is this content?")'
+            report_type:
+              blank: 'is required (please answer "What are you reporting?")'

config/routes.rb

@@ -378,6 +378,7 @@
     root                                   to: 'complaints#index', as: :safety_center
     get    'report',                       to: 'complaints#report', as: :new_complaint
     post   'report',                       to: 'complaints#create', as: :create_complaint
+    get    'report/:token',                to: 'complaints#show', as: :complaint
   end
 
   get   '403',                             to: 'errors#forbidden'

test/controllers/complaints_controller_test.rb

@@ -1,6 +1,8 @@
 require 'test_helper'
 
 class ComplaintsControllerTest < ActionDispatch::IntegrationTest
+  include Devise::Test::IntegrationHelpers
+
   test 'should get safety center' do
     get safety_center_path
     assert_response(:success)
@@ -34,4 +36,36 @@ class ComplaintsControllerTest < ActionDispatch::IntegrationTest
     get new_complaint_path
     assert_response(:success)
   end
+
+  test 'should use signed in user email if available' do
+    sign_in users(:basic_user)
+    try_create_report report_type: 'illegal', reported_url: 'https://example.com', content_type: 'fraud',
+                      content: 'test', email: 'something@else.com', user_wants_updates: true
+    assert_response :found
+    assert_not_nil assigns(:complaint)
+    #assert_redirected_to complaint_path(@complaint.access_token)
+    assert_equal users(:basic_user).email, assigns(:complaint).email
+  end
+
+  test 'should create report for anonymous user and use email provided' do
+    try_create_report report_type: 'illegal', reported_url: 'https://example.com', content_type: 'fraud',
+                      content: 'test', email: 'something@else.com', user_wants_updates: true
+    assert_response :found
+    assert_not_nil assigns(:complaint)
+    #assert_redirected_to complaint_path(@complaint.access_token)
+    assert_equal 'something@else.com', assigns(:complaint).email
+  end
+
+  test 'should correctly validate fields for report' do
+    try_create_report user_wants_updates: true
+    assert_response :bad_request
+    assert_not_nil assigns(:complaint)
+    assert_equal 3, assigns(:errors).size
+  end
+
+  private
+
+  def try_create_report(**params)
+    post create_complaint_path, params: params
+  end
 end