Merge pull request #1873 from codidact/cellio/714-rename-thread

Author: ArtOfCode-

app/controllers/comments_controller.rb

@@ -220,13 +220,32 @@ def thread_rename
       return
     end
 
+    orig_title = @comment_thread.title
     title = helpers.strip_markdown(params[:title], strip_leading_quote: true)
     status = @comment_thread.update(title: title)
 
+    if status
+      # Comment is owned by System so regular users can't delete it. Without
+      # this record, the title would be attributed to the thread creator,
+      # which can be abused.
+      log_msg =
+        Comment.new(post: @post,
+                    content:
+                      "Thread renamed from \\\"#{orig_title}\\\" to \\\"#{title}\\\" by @##{current_user.id}",
+                    user: User.find(-1),
+                    comment_thread: @comment_thread,
+                    has_reference: false)
+      comment_status = log_msg.save
+    end
+
     unless status
       flash[:danger] = I18n.t('comments.errors.rename_thread_generic')
     end
 
+    unless comment_status
+      flash[:danger] = I18n.t('comments.errors.comment_not_posted')
+    end
+
     redirect_to comment_thread_path(@comment_thread.id)
   end
 

app/models/user.rb

@@ -88,6 +88,14 @@ def post_privilege?(name, post)
     post.user == self || privilege?(name)
   end
 
+  # Can the user rename a given comment thread?
+  # @param thread [CommentThread] thread to rename
+  # @return [Boolean] check result
+  def can_rename?(thread)
+    privilege?('flag_curate') ||
+      Comment.where(user: self, comment_thread_id: thread.id).any?
+  end
+
   # Can the user archive a given comment thread?
   # @param thread [CommentThread] thread to archive
   # @return [Boolean] check result

app/views/comment_threads/_expanded.html.erb

@@ -1,13 +1,14 @@
 <%#
-    Full thread view with all the details & actions
+   "Full thread view with all the details & actions
 
     Variables:
     ? comment_id   : Comment ID to show even if it would be hidden otherwise
       inline       : whether the thread is diplayed inline with the parent post
       show_deleted : whether to display deleted comments for those who can see them
       thread       : CommentThread to display
-%>
+"%>
 
+<% can_only_rename = current_user&.can_rename?(thread) && !current_user&.privilege?('flag_curate') %>
 <% max_shown_comments = 5 %>
 <% comment_id ||= defined?(comment_id) ? comment_id : nil %>
 <% pingable = thread.pingable %>
@@ -38,6 +39,15 @@
         <a href="<%= comment_thread_path(thread.id) %>" class="widget--header-link">show thread</a>
         <a href="javascript:void(0)" class="js-collapse-thread widget--header-link">collapse</a>
       <% end %>
+      <% if can_only_rename %>
+      <a href="javascript:void(0)"
+         class="widget--header-link"
+         data-modal=".js--rename-thread-<%= thread.id %>"
+         role="button"
+         aria-label="Rename thread">
+        <i class="fas fa-pen fa-fw"></i> rename
+      </a>
+      <% end %>
       <% if current_user&.privilege?('flag_curate') %>
         <%= render 'comments/thread_tools_link', thread: thread %>
       <% end %>
@@ -107,6 +117,10 @@
   <% end %>
 <% end %>
 
+<% if can_only_rename %>
+  <%= render 'comments/rename_thread_modal', thread: thread %>
+<% end %>
+
 <% if current_user&.privilege?('flag_curate') %>
   <%= render 'comments/thread_actions_modal', thread: thread, user: current_user %>
 <% end %>

config/locales/strings/en.comments.yml

@@ -33,6 +33,8 @@ en:
         Failed to rename the thread.
       title_presence: >
         can't be empty after Markdown is removed.
+      comment_not_posted: >
+        Failed to create comment.
     labels:
       create_new_thread: >
         Start new comment thread