made sorting type titles configurable & adjusted titles for flag queue sorting to match

Author: Oaphi

app/views/flags/handled.html.erb

@@ -14,7 +14,7 @@
 
   <%= render 'shared/sorting', default_order: @default_sort_order,
                                default_type: @default_sort_type,
-                               types: %w[age handled] %>
+                               types: ['age', { type: 'handled', title: 'time handled' }] %>
 </div>
 
 <% @flags.each do |flag| %>

app/views/flags/queue.html.erb

@@ -19,9 +19,13 @@
     <% end %>
   </div>
 
+  <% sorting_types = current_page?(escalated_flags_path) ?
+                      ['age', { type: 'escalated', title: 'time escalated' }] :
+                      %w[age] %>
+
   <%= render 'shared/sorting', default_order: @default_sort_order,
                                default_type: @default_sort_type,
-                               types: current_page?(escalated_flags_path) ? %w[age escalated] : %w[age] %>
+                               types: sorting_types %>
 </div>
 
 <% @flags.each do |flag| %>

app/views/shared/_sorting.html.erb

@@ -2,7 +2,7 @@
    "Renders a sorting widget
 
     Variables:
-      types : Array<String> of available sorting types
+      types         : list of available sorting types
     ? default_order : Defualt sorting order, if any
     ? default_type  : Default sorting type, if any
 "%>
@@ -16,13 +16,15 @@
 
 <div class="button-list is-gutterless">
 
-  <% types.each do |type| %>
+  <% types.each do |option| %>
+    <% type = option.is_a?(String) ? option : option[:type] %>
+    <% title = "Sort by #{option.is_a?(String) ? option.humanize.downcase : option[:title]}" %>
     <% is_active = params[:sort] == type || (params[:sort].nil? && default_type.to_s == type) %>
     <%= link_to request.params.merge(sort: type, order: is_active ? reverse_order : nil),
                 class: "button is-muted is-outlined #{'is-active' if is_active}",
                 role: 'button',
-                title: "Sort by #{type.humanize.downcase}",
-                aria: { label: "Sort by #{type.humanize.downcase}" } do %>
+                title: title,
+                aria: { label: title } do %>
       <% if is_active %>
         <i class="has-margin-right-1 fa fa-caret-<%= order == :asc ? 'up' : 'down' %>"></i> <%= type.humanize %>
       <% else %>