feat: Fixes testing harness for linux. Fix syncthing for linux

Author: kevinwang5658

scripts/run-tests.ts

@@ -98,7 +98,7 @@ async function launchPersistentTest(test: string, debug: boolean, operatingSyste
 
   console.log('Done refreshing files on VM. Starting tests...');
   VerbosityLevel.set(3);
-  await codifySpawn(`tart exec -i ${vmName} ${shell} -c -i "cd ${dir} && FORCE_COLOR=true npm run test -- ${test} --disable-console-intercept ${debugFlag} --no-file-parallelism"`, { throws: false });
+  await codifySpawn(`tart exec -i ${vmName} ${shell} -c -i 'cd ${dir} && XDG_RUNTIME_DIR="/run/user/$(id -u)" DBUS_SESSION_BUS_ADDRESS="unix:path=$XDG_RUNTIME_DIR/bus" FORCE_COLOR=true npm run test -- ${test} --disable-console-intercept ${debugFlag} --no-file-parallelism'`, { throws: false });
   // }
 }
 
@@ -128,7 +128,17 @@ async function launchPersistentVm(operatingSystem: string) {
   } else {
     await testSpawn(`tart exec ${newVmName} ${shell} -i -c "curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.40.4/install.sh | bash"`)
     await testSpawn(`tart exec ${newVmName} ${shell} -i -c "nvm install 24; nvm alias default 24"`)
+
+    // XDG_RUNTIME_DIR is required by systemd user services (e.g. `systemctl --user`). On desktop
+    // Linux it is set automatically by PAM/logind on graphical login, but non-interactive SSH/tart
+    // sessions skip that path, so we set it explicitly to the canonical location /run/user/<uid>.
     await testSpawn(`tart exec ${newVmName} ${shell} -i -c "echo 'export XDG_RUNTIME_DIR=/run/user/$(id -u)' >> ~/.bashrc"`)
+
+    // enable-linger keeps the user's systemd session alive after logout. Without it, user-scoped
+    // systemd units (like syncthing.service) are stopped when the tart session ends, which causes
+    // `systemctl --user enable --now` to fail during integration tests.
+    await testSpawn(`tart exec ${newVmName} ${shell} -i -c "loginctl enable-linger admin"`)
+
   }
 
   await testSpawn(`tart exec ${newVmName} ${shell} -i -c "cd ~/codify-homebrew-plugin && npm ci"`);

src/resources/syncthing/syncthing.ts

@@ -237,17 +237,17 @@ export class SyncthingResource extends Resource<SyncthingConfig> {
     const $ = getPty();
 
     // Add the official Syncthing apt repository
-    await $.spawn('sudo mkdir -p /etc/apt/keyrings', { interactive: true });
+    await $.spawn('mkdir -p /etc/apt/keyrings', { interactive: true, requiresRoot: true });
     await $.spawn(
-      'sudo curl -L -o /etc/apt/keyrings/syncthing-archive-keyring.gpg https://syncthing.net/release-key.gpg',
-      { interactive: true }
+      'curl -L -o /etc/apt/keyrings/syncthing-archive-keyring.gpg https://syncthing.net/release-key.gpg',
+      { interactive: true, requiresRoot: true }
     );
     await $.spawn(
-      'echo "deb [signed-by=/etc/apt/keyrings/syncthing-archive-keyring.gpg] https://apt.syncthing.net/ syncthing stable" | sudo tee /etc/apt/sources.list.d/syncthing.list',
-      { interactive: true }
+      'bash -c \'echo "deb [signed-by=/etc/apt/keyrings/syncthing-archive-keyring.gpg] https://apt.syncthing.net/ syncthing stable" > /etc/apt/sources.list.d/syncthing.list\'',
+      { interactive: true, requiresRoot: true }
     );
-    await $.spawn('sudo apt-get update', { interactive: true });
-    await $.spawn('sudo apt-get install -y syncthing', { interactive: true });
+    await $.spawn('apt-get update', { interactive: true, requiresRoot: true });
+    await $.spawn('apt-get install -y syncthing', { interactive: true, requiresRoot: true });
 
     const shouldLaunchAtStartup = config.launchAtStartup ?? true;
     await this.setLaunchAtStartup(shouldLaunchAtStartup);
@@ -260,9 +260,9 @@ export class SyncthingResource extends Resource<SyncthingConfig> {
     const $ = getPty();
     await $.spawnSafe('systemctl --user stop syncthing');
     await $.spawnSafe('systemctl --user disable syncthing');
-    await $.spawnSafe('sudo apt-get remove -y syncthing');
-    await $.spawnSafe('sudo rm -f /etc/apt/sources.list.d/syncthing.list');
-    await $.spawnSafe('sudo rm -f /etc/apt/keyrings/syncthing-archive-keyring.gpg');
+    await $.spawnSafe('apt-get remove -y syncthing', { requiresRoot: true });
+    await $.spawnSafe('rm -f /etc/apt/sources.list.d/syncthing.list', { requiresRoot: true });
+    await $.spawnSafe('rm -f /etc/apt/keyrings/syncthing-archive-keyring.gpg', { requiresRoot: true });
   }
 
   // ── Service management ────────────────────────────────────────────────────

test/syncthing/syncthing.test.ts

@@ -210,9 +210,9 @@ describe('Syncthing resource integration tests', async () => {
       await testSpawn('brew services stop syncthing');
       await testSpawn('brew uninstall syncthing');
     } else {
-      await testSpawn('systemctl --user stop syncthing');
-      await testSpawn('systemctl --user disable syncthing');
-      await testSpawn('sudo apt-get remove -y syncthing');
+      // await testSpawn('systemctl --user stop syncthing');
+      // await testSpawn('systemctl --user disable syncthing');
+      // await testSpawn('apt-get remove -y syncthing', { requiresRoot: true });
     }
   }, 60_000);
 });