[CODE-102] Add check if cask could not install properly

Author: kevinwang5658

src/resources/homebrew/casks-parameter.ts

@@ -63,6 +63,12 @@ export class CasksParameter extends ArrayStatefulParameter<HomebrewConfig, strin
     const result = await codifySpawn(`SUDO_ASKPASS=${SUDO_ASKPASS_PATH} brew install --casks ${casks.join(' ')}`)
 
     if (result.status === SpawnStatus.SUCCESS) {
+
+      // Casks can't detect if a program was installed by other means. If it returns this message, throw an error
+      if (result.data.includes('It seems there is already an App at')) {
+        throw new Error(`A program already exists for cask ${casks}`)
+      }
+
       console.log(`Installed casks: ${casks.join(' ')}`);
     } else {
       throw new Error(`Failed to install casks: ${casks}. ${JSON.stringify(result.data, null, 2)}`)

src/resources/homebrew/homebrew.ts

@@ -36,10 +36,6 @@ export class HomebrewResource extends Resource<HomebrewConfig> {
     });
   }
 
-  async onInitialize(): Promise<void> {
-    await this.saveSudoAskpassIfNotExists();
-  }
-
   async refresh(parameters: Partial<HomebrewConfig>): Promise<Partial<HomebrewConfig> | null> {
     const homebrewInfo = await codifySpawn('brew config', { throws: false });
     if (homebrewInfo.status === SpawnStatus.ERROR) {
@@ -55,6 +51,8 @@ export class HomebrewResource extends Resource<HomebrewConfig> {
   }
 
   async applyCreate(plan: CreatePlan<HomebrewConfig>): Promise<void> {
+    await this.saveSudoAskpassIfNotExists();
+
     if (plan.desiredConfig.directory) {
       return this.installBrewInCustomDir(plan.desiredConfig.directory)
     }