Fixed: crash when opening Settings on devices with API level 10 and below

codinguser · codinguser · commit 0168c508afc1 · 2013-06-22T17:26:28.000+02:00
Implemented deleting all accounts and transactions for devices with API level 10 and below Closes #95
diff --git a/app/res/values-de/strings.xml b/app/res/values-de/strings.xml
@@ -338,6 +338,7 @@
     <string name="title_delete_all_transactions">Delete all transactions</string>
     <string name="toast_all_transactions_deleted">All transactions successfully deleted!</string>
     <string name="title_progress_importing_accounts">Importing accounts</string>
+    <string name="toast_tap_again_to_confirm_delete">Tap again to confirm. ALL entries will be deleted!!</string>
     <plurals name="label_sub_accounts">
         <item quantity="one">%d Unterkonto</item>
         <item quantity="other">%d Unterkonten</item>
diff --git a/app/res/values-el/strings.xml b/app/res/values-el/strings.xml
@@ -352,6 +352,7 @@
     <string name="toast_all_transactions_deleted">Όλες οι κινήσεις διαγράφηκαν
 	με επιτυχία!</string>
     <string name="title_progress_importing_accounts">Importing accounts</string>
+    <string name="toast_tap_again_to_confirm_delete">Tap again to confirm. ALL entries will be deleted!!</string>
     <plurals name="label_sub_accounts">
         <item quantity="one">%d υπο-λογαριασμός</item>
         <item quantity="other">%d υπο-λογαριασμοί</item>
diff --git a/app/res/values-es-rMX/strings.xml b/app/res/values-es-rMX/strings.xml
@@ -335,6 +335,7 @@
     <string name="title_delete_all_transactions">Borrar todas las transacciones</string>
     <string name="toast_all_transactions_deleted">&#161;Todas las transacciones han sido borradas con exit&#243;samente!</string>
     <string name="title_progress_importing_accounts">Importing accounts</string>
+    <string name="toast_tap_again_to_confirm_delete">Tap again to confirm. ALL entries will be deleted!!</string>
     <plurals name="label_sub_accounts">
         <item quantity="one">%d subcuenta</item>
         <item quantity="other">%d subcuentas</item>
diff --git a/app/res/values-es/strings.xml b/app/res/values-es/strings.xml
@@ -336,6 +336,7 @@
     <string name="title_delete_all_transactions">Borrar todas las transacciones</string>
     <string name="toast_all_transactions_deleted">Todas las transacciones han sido borradas con &#233;xito</string>
     <string name="title_progress_importing_accounts">Importing accounts</string>
+    <string name="toast_tap_again_to_confirm_delete">Tap again to confirm. ALL entries will be deleted!!</string>
     <plurals name="label_sub_accounts">
         <item quantity="one">%d sub-cuenta</item>
         <item quantity="other">%d sub-cuentas</item>
diff --git a/app/res/values-fr/strings.xml b/app/res/values-fr/strings.xml
@@ -334,6 +334,7 @@
     <string name="title_delete_all_transactions">Supprimer toutes les transactions</string>
     <string name="toast_all_transactions_deleted">Toutes les transactions ont &#233;t&#233; supprim&#233;es avec succ&#232;s!</string>
     <string name="title_progress_importing_accounts">Importing accounts</string>
+    <string name="toast_tap_again_to_confirm_delete">Tap again to confirm. ALL entries will be deleted!!</string>
     <plurals name="label_sub_accounts">
         <item quantity="one">%d sous-compte</item>
         <item quantity="other">%d sous-comptes</item>
diff --git a/app/res/values-hu/strings.xml b/app/res/values-hu/strings.xml
@@ -337,6 +337,7 @@
     <string name="title_delete_all_transactions">Delete all transactions</string>
     <string name="toast_all_transactions_deleted">All transactions successfully deleted!</string>
     <string name="title_progress_importing_accounts">Importing accounts</string>
+    <string name="toast_tap_again_to_confirm_delete">Tap again to confirm. ALL entries will be deleted!!</string>
     <plurals name="label_sub_accounts">
         <item quantity="one">%d sub-account</item>
         <item quantity="other">%d sub-accounts</item>
diff --git a/app/res/values-it/strings.xml b/app/res/values-it/strings.xml
@@ -337,6 +337,7 @@
     <string name="title_delete_all_transactions">Elimina tutte le transazioni</string>
     <string name="toast_all_transactions_deleted">Tutte le transazioni sono state eliminate!</string>
     <string name="title_progress_importing_accounts">Importing accounts</string>
+    <string name="toast_tap_again_to_confirm_delete">Tap again to confirm. ALL entries will be deleted!!</string>
     <plurals name="label_sub_accounts">
         <item quantity="one">%d sotto-conto</item>
         <item quantity="other">%d sotto-conti</item>
diff --git a/app/res/values-nb/strings.xml b/app/res/values-nb/strings.xml
@@ -339,6 +339,7 @@ format og importeres i regnskapsprogrammet GnuCash for PC.</string>
     <string name="title_delete_all_transactions">Slette alle transaksjoner</string>
     <string name="toast_all_transactions_deleted">Alle transaksjoner slettet!</string>
     <string name="title_progress_importing_accounts">Importing accounts</string>
+    <string name="toast_tap_again_to_confirm_delete">Tap again to confirm. ALL entries will be deleted!!</string>
     <plurals name="label_sub_accounts">
         <item quantity="one">%d under-konto</item>
         <item quantity="other">%d under-kontoer</item>
diff --git a/app/res/values-nl/strings.xml b/app/res/values-nl/strings.xml
@@ -338,6 +338,7 @@
     <string name="title_delete_all_transactions">Delete all transactions</string>
     <string name="toast_all_transactions_deleted">All transactions successfully deleted!</string>
     <string name="title_progress_importing_accounts">Importing accounts</string>
+    <string name="toast_tap_again_to_confirm_delete">Tap again to confirm. ALL entries will be deleted!!</string>
     <plurals name="label_sub_accounts">
         <item quantity="one">%d sub-account</item>
         <item quantity="other">%d sub-accounts</item>
diff --git a/app/res/values-pt-rBR/strings.xml b/app/res/values-pt-rBR/strings.xml
@@ -337,6 +337,7 @@
     <string name="title_delete_all_transactions">Delete all transactions</string>
     <string name="toast_all_transactions_deleted">All transactions successfully deleted!</string>
     <string name="title_progress_importing_accounts">Importing accounts</string>
+    <string name="toast_tap_again_to_confirm_delete">Tap again to confirm. ALL entries will be deleted!!</string>
     <plurals name="label_sub_accounts">
         <item quantity="one">%d sub-account</item>
         <item quantity="other">%d sub-accounts</item>
diff --git a/app/res/values-ru/strings.xml b/app/res/values-ru/strings.xml
@@ -334,6 +334,7 @@
     <string name="title_delete_all_transactions">Удалить все проводки</string>
     <string name="toast_all_transactions_deleted">Все проводки удалены!</string>
     <string name="title_progress_importing_accounts">Importing accounts</string>
+    <string name="toast_tap_again_to_confirm_delete">Tap again to confirm. ALL entries will be deleted!!</string>
     <plurals name="label_sub_accounts">
         <item quantity="one">%d дочерний счёт</item>
         <item quantity="other">%d шт. дочерних счетов</item>
diff --git a/app/res/values/strings.xml b/app/res/values/strings.xml
@@ -534,6 +534,7 @@
     <string name="title_delete_all_transactions">Delete all transactions</string>
     <string name="toast_all_transactions_deleted">All transactions successfully deleted!</string>
     <string name="title_progress_importing_accounts">Importing accounts</string>
+    <string name="toast_tap_again_to_confirm_delete">Tap again to confirm. ALL entries will be deleted!!</string>
     <plurals name="label_sub_accounts">
         <item quantity="one">%d sub-account</item>
         <item quantity="other">%d sub-accounts</item>
diff --git a/app/res/xml/fragment_account_preferences.xml b/app/res/xml/fragment_account_preferences.xml
@@ -11,4 +11,7 @@
     <Preference android:key="@string/key_import_accounts"
                 android:summary="@string/summary_import_accounts"
                 android:title="@string/title_import_accounts" />
+    <Preference android:key="@string/key_delete_all_accounts"
+                android:summary="@string/summary_delete_all_accounts"
+                android:title="@string/title_delete_all_accounts" />
 </PreferenceScreen>
diff --git a/app/res/xml/fragment_transaction_preferences.xml b/app/res/xml/fragment_transaction_preferences.xml
@@ -24,4 +24,7 @@
     <CheckBoxPreference android:summary="@string/summary_use_double_entry"
                         android:key="@string/key_use_double_entry"
                         android:title="@string/title_use_double_entry"/>
+    <Preference android:key="@string/key_delete_all_transactions"
+                android:summary="@string/summary_delete_all_transactions"
+                android:title="@string/title_delete_all_transactions" />
 </PreferenceScreen>
diff --git a/app/src/org/gnucash/android/ui/settings/SettingsActivity.java b/app/src/org/gnucash/android/ui/settings/SettingsActivity.java
@@ -27,18 +27,22 @@
 import android.preference.Preference.OnPreferenceChangeListener;
 import android.preference.PreferenceManager;
 import android.util.Log;
+import android.view.View;
+import android.widget.AdapterView;
 import android.widget.Toast;
 import com.actionbarsherlock.app.ActionBar;
 import com.actionbarsherlock.app.SherlockPreferenceActivity;
 import com.actionbarsherlock.view.MenuItem;
 import org.gnucash.android.R;
 import org.gnucash.android.data.Money;
+import org.gnucash.android.db.AccountsDbAdapter;
+import org.gnucash.android.db.TransactionsDbAdapter;
 import org.gnucash.android.ui.accounts.AccountsActivity;
 import org.gnucash.android.ui.accounts.AccountsListFragment;
-import org.gnucash.android.util.GnucashAccountXmlHandler;
 
-import java.io.FileNotFoundException;
 import java.util.List;
+import java.util.Timer;
+import java.util.TimerTask;
 
 /**
  * Activity for displaying settings and information about the application
@@ -47,6 +51,21 @@
  */
 public class SettingsActivity extends SherlockPreferenceActivity implements OnPreferenceChangeListener, Preference.OnPreferenceClickListener{
 
+    public static final int DOUBLE_TAP_DELAY = 2000;
+    /**
+     * Counts the number of times the preference for deleting all accounts has been clicked.
+     * It is reset every time the SettingsActivity is resumed.
+     * Only useful on devices with API level < 11
+     */
+    private int mDeleteAccountsClickCount;
+
+    /**
+     * Counts the number of times the preference for deleting all transactions has been clicked.
+     * It is reset every time the SettingsActivity is resumed.
+     * Only useful on devices with API level < 11
+     */
+    private int mDeleteTransactionsClickCount;
+
 	/**
 	 * Constructs the headers to display in the header list when the Settings activity is first opened
 	 * Only available on Honeycomb and above
@@ -100,8 +119,15 @@ protected void onCreate(Bundle savedInstanceState) {
             pref.setOnPreferenceClickListener(this);
 		}
 	}
-		
-	@Override
+
+    @Override
+    protected void onResume() {
+        super.onResume();
+        mDeleteAccountsClickCount = 0;
+        mDeleteTransactionsClickCount = 0;
+    }
+
+    @Override
 	public boolean onOptionsItemSelected(MenuItem item) {
 		switch (item.getItemId()) {
 		case android.R.id.home:		
@@ -148,9 +174,51 @@ public boolean onPreferenceClick(Preference preference) {
             return true;
         }
 
+        //since we cannot get a support FragmentManager in the SettingsActivity pre H0NEYCOMB,
+        //we will just use 2 taps within 2 seconds as confirmation
+        if (key.equals(getString(R.string.key_delete_all_accounts))){
+            mDeleteAccountsClickCount++;
+            if (mDeleteAccountsClickCount < 2){
+                Toast.makeText(this, R.string.toast_tap_again_to_confirm_delete, Toast.LENGTH_SHORT).show();
+            } else {
+                AccountsDbAdapter accountsDbAdapter = new AccountsDbAdapter(this);
+                accountsDbAdapter.deleteAllRecords();
+                accountsDbAdapter.close();
+                Toast.makeText(this, R.string.toast_all_accounts_deleted, Toast.LENGTH_LONG).show();
+            }
+            Timer timer = new Timer();
+            timer.schedule(new ResetCounter(), DOUBLE_TAP_DELAY);
+        }
+
+        if (key.equals(getString(R.string.key_delete_all_transactions))){
+            mDeleteTransactionsClickCount++;
+            if (mDeleteTransactionsClickCount < 2){
+                Toast.makeText(this, R.string.toast_tap_again_to_confirm_delete, Toast.LENGTH_SHORT).show();
+            } else {
+                TransactionsDbAdapter transactionsDbAdapter = new TransactionsDbAdapter(this);
+                transactionsDbAdapter.deleteAllRecords();
+                transactionsDbAdapter.close();
+                Toast.makeText(this, R.string.toast_all_transactions_deleted, Toast.LENGTH_LONG).show();
+            }
+            Timer timer = new Timer();
+            timer.schedule(new ResetCounter(), DOUBLE_TAP_DELAY);
+        }
+
         return false;
     }
 
+    /**
+     * Resets the tap counter for preferences which need to be double-tapped
+     */
+    private class ResetCounter extends TimerTask{
+
+        @Override
+        public void run() {
+            mDeleteAccountsClickCount = 0;
+            mDeleteTransactionsClickCount = 0;
+        }
+    };
+
     public void importAccounts() {
         Intent pickIntent = new Intent(Intent.ACTION_GET_CONTENT);
         pickIntent.setType("application/octet-stream");
