Updated version numbers for 1.2.3 release

Increased touch target area for "new transaction" button in accounts list view

Author: codinguser

CHANGELOG.md

@@ -1,12 +1,13 @@
 Change Log
 ===============================================================================
-Version 1.2.3.beta2 *(2013-08-27)*
+Version 1.2.3 *(2013-08-28)*
 ----------------------------
+* Fixed: crashes when editing/creating transactions
 * Feature: Added Chinese language translation
 * Feature: Autocomplete transaction descriptions
-* Fixed: crash when creating transactions or updating widget
 * Improved reliability of importing stock accounts
 * Improved speed of loading account balance
+* Improved incrased touch target area of "new transaction" button in accounts list view
 
 Version 1.2.2 *(2013-06-23)*
 ----------------------------

app/AndroidManifest.xml

@@ -17,8 +17,8 @@
 
 <manifest xmlns:android="http://schemas.android.com/apk/res/android"
     package="org.gnucash.android"
-    android:versionCode="12"
-    android:versionName="1.2.3.beta2" >
+    android:versionCode="13"
+    android:versionName="1.2.3" >
 
     <uses-sdk android:minSdkVersion="8" android:targetSdkVersion="15"/>
 

app/pom.xml

@@ -22,7 +22,7 @@
     <description>Gnucash Android companion application</description>
 
     <parent>
-        <version>1.2.3-SNAPSHOT</version>
+        <version>1.2.3</version>
         <groupId>org.gnucash.android</groupId>
         <artifactId>gnucash-android-parent</artifactId>
     </parent>

app/res/drawable/selected_background.xml

@@ -0,0 +1,8 @@
+<?xml version="1.0" encoding="utf-8"?>
+
+<selector xmlns:android="http://schemas.android.com/apk/res/android">
+    <item android:drawable="@drawable/abs__item_background_holo_light"
+          android:state_pressed="true" />
+    <item android:drawable="@drawable/abs__item_background_holo_light"
+          android:state_focused="true" />
+</selector>

app/res/layout/list_item_account.xml

@@ -23,7 +23,6 @@
               android:paddingRight="@dimen/edge_padding"
               android:orientation="horizontal"
               style="@style/ListItem">
-
     <include
             layout="@layout/list_item_2_lines"
             android:layout_height="wrap_content"
@@ -48,13 +47,15 @@
             android:layout_marginRight="10dp"
             />
 
-    <ImageView
+    <ImageButton
             android:id="@+id/btn_new_transaction"
             android:layout_width="wrap_content"
-            android:layout_height="wrap_content"
-            android:background="@drawable/content_new_holo_light"
+            android:layout_height="match_parent"
+            android:src="@drawable/content_new_holo_light"
+            style="@style/ImageButton.Transparent"
             android:padding="2dp"
             android:clickable="true"
+            android:focusable="false"
             android:contentDescription="@string/description_add_transaction_icon"/>
 
 </LinearLayout>

app/res/values-v14/styles.xml

@@ -0,0 +1,6 @@
+<?xml version="1.0" encoding="utf-8"?>
+<resources>
+    <style name="ImageButton.Transparent" parent="@android:style/Widget.ImageButton">
+        <item name="android:background">?android:attr/selectableItemBackground</item>
+    </style>
+</resources>

app/res/values/styles.xml

@@ -80,4 +80,9 @@
         <item name="android:textSize">12sp</item>
         <item name="android:textAppearance">?android:attr/textAppearanceSmall</item>
     </style>
+
+    <style name="ImageButton.Transparent" parent="@android:style/Widget.ImageButton">
+        <item name="android:background">@drawable/selected_background</item>
+    </style>
+
 </resources>

app/src/org/gnucash/android/ui/accounts/AccountsListFragment.java

@@ -609,7 +609,7 @@ public void bindView(View v, Context context, Cursor cursor) {
                     .findViewById(R.id.transactions_summary);
             new AccountBalanceTask(summary, getActivity()).execute(accountId);
 
-            ImageView newTransactionButton = (ImageView) v.findViewById(R.id.btn_new_transaction);
+            ImageButton newTransactionButton = (ImageButton) v.findViewById(R.id.btn_new_transaction);
             if (inSubAcccount()){
                 newTransactionButton.setVisibility(View.GONE);
                 v.findViewById(R.id.vertical_line).setVisibility(View.GONE);
@@ -625,6 +625,7 @@ public void onClick(View v) {
                     }
                 });
             }
+            newTransactionButton.setFocusable(false);
         }
     }
 

integration-tests/AndroidManifest.xml

@@ -2,7 +2,7 @@
 <manifest xmlns:android="http://schemas.android.com/apk/res/android"
     package="org.gnucash.android.test"
     android:versionCode="3"
-    android:versionName="1.2.0" >
+    android:versionName="1.2.3" >
 
     <uses-sdk android:minSdkVersion="8" android:targetSdkVersion="15" />
 

integration-tests/pom.xml

@@ -17,7 +17,7 @@
 <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
     <modelVersion>4.0.0</modelVersion>
     <parent>
-		<version>1.2.3-SNAPSHOT</version>
+		<version>1.2.3</version>
 		<groupId>org.gnucash.android</groupId>
 		<artifactId>gnucash-android-parent</artifactId>
 	</parent>