Skip to content

Commit 7c4087c

Browse files
committed
Fixed: transactions not saved when double-entry enabled but no transfer account specified
Fixes #277
1 parent 2b05d00 commit 7c4087c

2 files changed

Lines changed: 11 additions & 3 deletions

File tree

app/src/main/java/org/gnucash/android/ui/transaction/TransactionFormFragment.java

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -742,8 +742,14 @@ public boolean onOptionsItemSelected(MenuItem item) {
742742
}
743743
else if (mAmountEditText.getText().length() == 0) {
744744
Toast.makeText(getActivity(), R.string.toast_transanction_amount_required, Toast.LENGTH_SHORT).show();
745-
} else
746-
saveNewTransaction();
745+
} else if (mUseDoubleEntry && mDoubleAccountSpinner.getCount() == 0){
746+
//TODO: Or automatically create an imbalance account
747+
Toast.makeText(getActivity(),
748+
"Create & specify a transfer account OR disable double-entry in settings to save the transaction",
749+
Toast.LENGTH_LONG).show();
750+
} else {
751+
saveNewTransaction();
752+
}
747753
return true;
748754

749755
default:

integration-tests/src/main/java/org/gnucash/android/test/ui/TransactionsActivityTest.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,9 @@ private void validateEditTransactionFields(Transaction transaction){
188188
actualValue = timeView.getText().toString();// mSolo.getText(7).getText().toString();
189189
assertEquals(expectedValue, actualValue);
190190
}
191-
191+
192+
//TODO: Add test for only one account but with double-entry enabled
193+
192194
public void testAddTransaction(){
193195
setDoubleEntryEnabled(true);
194196
mSolo.waitForText(TRANSACTION_NAME);

0 commit comments

Comments
 (0)