Commit 5c8a4ec
committed
fix: Address review feedback for embed_stream
1. V2 embed_stream mishandles duplicate texts (High):
- Added used_batch_indices tracking like base_client
- Now correctly assigns unique indices to duplicate texts
2. Unused variable total_embeddings_yielded (Low):
- Removed from both base_client.py and v2/client.py1 parent a1955f7 commit 5c8a4ec
2 files changed
Lines changed: 14 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1207 | 1207 | | |
1208 | 1208 | | |
1209 | 1209 | | |
1210 | | - | |
1211 | 1210 | | |
1212 | 1211 | | |
1213 | 1212 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
583 | 583 | | |
584 | 584 | | |
585 | 585 | | |
586 | | - | |
587 | 586 | | |
588 | 587 | | |
589 | 588 | | |
| |||
600 | 599 | | |
601 | 600 | | |
602 | 601 | | |
603 | | - | |
| 602 | + | |
604 | 603 | | |
605 | 604 | | |
| 605 | + | |
| 606 | + | |
| 607 | + | |
606 | 608 | | |
607 | 609 | | |
608 | 610 | | |
609 | 611 | | |
610 | | - | |
611 | | - | |
| 612 | + | |
| 613 | + | |
| 614 | + | |
| 615 | + | |
| 616 | + | |
| 617 | + | |
| 618 | + | |
| 619 | + | |
| 620 | + | |
| 621 | + | |
612 | 622 | | |
613 | 623 | | |
614 | 624 | | |
| |||
0 commit comments