REFACTOR: Rename loop variables for clarity and consistency

- Renamed `kw` to `keyword_item` in dataclass config check
- Renamed `target` to `target_element` in module import checks
- Renamed `alias` to `alias_element` in import many names check
- Renamed `usage` to `usage_element` in temp var check
- Renamed `verb` to `verb_name` in function verb check
- Renamed `item` to `violation_item` in test assertions
- Renamed `v` to `cop013_violation` in module level validation test

These changes improve code readability by using more descriptive
variable names
that clearly indicate their purpose

Author: vrslev

src/community_of_python_flake8_plugin/checks/dataclass_config.py

@@ -24,7 +24,11 @@ def has_required_dataclass_params(decorator: ast.expr) -> bool:
     if not isinstance(decorator, ast.Call):
         return False
 
-    keywords: typing.Final = {kw.arg: kw.value for kw in decorator.keywords if isinstance(kw.value, ast.Constant)}
+    keywords: typing.Final = {
+        keyword_item.arg: keyword_item.value
+        for keyword_item in decorator.keywords
+        if isinstance(keyword_item.value, ast.Constant)
+    }
     kw_only_param: typing.Final = keywords.get("kw_only")
     slots_param: typing.Final = keywords.get("slots")
     frozen_param: typing.Final = keywords.get("frozen")

src/community_of_python_flake8_plugin/checks/disabled/module_import_many_names.py

@@ -19,7 +19,8 @@
 def check_module_has_all_declaration(module_node: ast.Module) -> bool:
     for statement in module_node.body:
         if isinstance(statement, ast.Assign) and any(
-            isinstance(target, ast.Name) and target.id == "__all__" for target in statement.targets
+            isinstance(target_element, ast.Name) and target_element.id == "__all__"
+            for target_element in statement.targets
         ):
             return True
         if (
@@ -76,9 +77,9 @@ def validate_import_size(self, ast_node: ast.ImportFrom) -> None:
             return
 
         if not any(
-            check_module_path_exists(f"{module_name}.{alias.name}")
-            for alias in ast_node.names
-            if isinstance(alias, ast.alias) and module_name is not None
+            check_module_path_exists(f"{module_name}.{alias_element.name}")
+            for alias_element in ast_node.names
+            if isinstance(alias_element, ast.alias) and module_name is not None
         ):
             self.violations.append(
                 Violation(

src/community_of_python_flake8_plugin/checks/function_verb.py

@@ -17,7 +17,7 @@ def check_is_ignored_name(identifier: str) -> bool:
 
 
 def check_is_verb_name(identifier: str) -> bool:
-    return any(identifier == verb or identifier.startswith(f"{verb}_") for verb in VERB_PREFIXES)
+    return any(identifier == verb_name or identifier.startswith(f"{verb_name}_") for verb_name in VERB_PREFIXES)
 
 
 def check_is_property(function_node: ast.AST) -> bool:

src/community_of_python_flake8_plugin/checks/temp_var.py

@@ -73,8 +73,8 @@ def _check_temporary_variables(self, ast_node: ast.FunctionDef | ast.AsyncFuncti
                 continue
 
             if (
-                len([usage for usage in usages if isinstance(usage.ctx, ast.Store)]) == 1
-                and len([usage for usage in usages if isinstance(usage.ctx, ast.Load)]) == 1
+                len([usage_element for usage_element in usages if isinstance(usage_element.ctx, ast.Store)]) == 1
+                and len([usage_element for usage_element in usages if isinstance(usage_element.ctx, ast.Load)]) == 1
                 and variable_name in usage_and_stores[1]
                 and not found_temporary_variable
             ):

tests/test_plugin.py

@@ -47,7 +47,10 @@
 )
 def test_import_stdlib_validations(input_source: str, expected_output: list[str]) -> None:
     assert sorted(
-        [item[2].split(" ")[0] for item in CommunityOfPythonFlake8Plugin(ast.parse(input_source)).run()]  # noqa: COP011
+        [
+            violation_item[2].split(" ")[0]
+            for violation_item in CommunityOfPythonFlake8Plugin(ast.parse(input_source)).run()
+        ]  # noqa: COP011
     ) == sorted(expected_output)
 
 
@@ -72,7 +75,10 @@ def test_import_stdlib_validations(input_source: str, expected_output: list[str]
 )
 def test_import_many_names_validations(input_source: str, expected_output: list[str]) -> None:
     assert sorted(
-        [item[2].split(" ")[0] for item in CommunityOfPythonFlake8Plugin(ast.parse(input_source)).run()]  # noqa: COP011
+        [
+            violation_item[2].split(" ")[0]
+            for violation_item in CommunityOfPythonFlake8Plugin(ast.parse(input_source)).run()
+        ]  # noqa: COP011
     ) == sorted(expected_output)
 
 
@@ -93,7 +99,10 @@ def test_import_many_names_validations(input_source: str, expected_output: list[
 )
 def test_type_annotation_validations(input_source: str, expected_output: list[str]) -> None:
     assert sorted(
-        [item[2].split(" ")[0] for item in CommunityOfPythonFlake8Plugin(ast.parse(input_source)).run()]  # noqa: COP011
+        [
+            violation_item[2].split(" ")[0]
+            for violation_item in CommunityOfPythonFlake8Plugin(ast.parse(input_source)).run()
+        ]  # noqa: COP011
     ) == sorted(expected_output)
 
 
@@ -257,7 +266,10 @@ def test_type_annotation_validations(input_source: str, expected_output: list[st
 )
 def test_naming_validations(input_source: str, expected_output: list[str]) -> None:
     assert sorted(
-        [item[2].split(" ")[0] for item in CommunityOfPythonFlake8Plugin(ast.parse(input_source)).run()]  # noqa: COP011
+        [
+            violation_item[2].split(" ")[0]
+            for violation_item in CommunityOfPythonFlake8Plugin(ast.parse(input_source)).run()
+        ]  # noqa: COP011
     ) == sorted(expected_output)
 
 
@@ -288,7 +300,10 @@ def test_naming_validations(input_source: str, expected_output: list[str]) -> No
 )
 def test_variable_usage_validations(input_source: str, expected_output: list[str]) -> None:
     assert sorted(
-        [item[2].split(" ")[0] for item in CommunityOfPythonFlake8Plugin(ast.parse(input_source)).run()]  # noqa: COP011
+        [
+            violation_item[2].split(" ")[0]
+            for violation_item in CommunityOfPythonFlake8Plugin(ast.parse(input_source)).run()
+        ]  # noqa: COP011
     ) == sorted(expected_output)
 
 
@@ -333,7 +348,10 @@ def test_variable_usage_validations(input_source: str, expected_output: list[str
 )
 def test_class_validations(input_source: str, expected_output: list[str]) -> None:
     assert sorted(
-        [item[2].split(" ")[0] for item in CommunityOfPythonFlake8Plugin(ast.parse(input_source)).run()]  # noqa: COP011
+        [
+            violation_item[2].split(" ")[0]
+            for violation_item in CommunityOfPythonFlake8Plugin(ast.parse(input_source)).run()
+        ]  # noqa: COP011
     ) == sorted(expected_output)
 
 
@@ -367,11 +385,14 @@ def test_class_validations(input_source: str, expected_output: list[str]) -> Non
 )
 def test_module_level_validations(input_source: str, expected_output: list[str]) -> None:
     assert [
-        v
-        for v in sorted(
-            [item[2].split(" ")[0] for item in CommunityOfPythonFlake8Plugin(ast.parse(input_source)).run()]
+        cop013_violation
+        for cop013_violation in sorted(
+            [
+                violation_item[2].split(" ")[0]
+                for violation_item in CommunityOfPythonFlake8Plugin(ast.parse(input_source)).run()
+            ]
         )
-        if v == "COP013"
+        if cop013_violation == "COP013"
     ] == expected_output
 
 
@@ -444,7 +465,10 @@ def test_module_level_validations(input_source: str, expected_output: list[str])
 )
 def test_dataclass_validations(input_source: str, expected_output: list[str]) -> None:
     assert sorted(
-        [item[2].split(" ")[0] for item in CommunityOfPythonFlake8Plugin(ast.parse(input_source)).run()]  # noqa: COP011
+        [
+            violation_item[2].split(" ")[0]
+            for violation_item in CommunityOfPythonFlake8Plugin(ast.parse(input_source)).run()
+        ]  # noqa: COP011
     ) == sorted(expected_output)
 
 
@@ -483,7 +507,10 @@ def test_dataclass_validations(input_source: str, expected_output: list[str]) ->
 )
 def test_module_vs_class_level_assignments(input_source: str, expected_output: list[str]) -> None:
     assert sorted(
-        [item[2].split(" ")[0] for item in CommunityOfPythonFlake8Plugin(ast.parse(input_source)).run()]  # noqa: COP011
+        [
+            violation_item[2].split(" ")[0]
+            for violation_item in CommunityOfPythonFlake8Plugin(ast.parse(input_source)).run()
+        ]  # noqa: COP011
     ) == sorted(expected_output)
 
 
@@ -499,5 +526,8 @@ def test_module_vs_class_level_assignments(input_source: str, expected_output: l
 )
 def test_combined_validations(input_source: str, expected_output: list[str]) -> None:
     assert sorted(
-        [item[2].split(" ")[0] for item in CommunityOfPythonFlake8Plugin(ast.parse(input_source)).run()]  # noqa: COP011
+        [
+            violation_item[2].split(" ")[0]
+            for violation_item in CommunityOfPythonFlake8Plugin(ast.parse(input_source)).run()
+        ]  # noqa: COP011
     ) == sorted(expected_output)