Enhance property decorator detection and add clear verb prefix

Author: vrslev

src/community_of_python_flake8_plugin/checks/function_verb.py

@@ -27,12 +27,26 @@ def check_is_property(function_node: ast.AST) -> bool:
 
 
 def check_is_property_decorator(decorator: ast.expr) -> bool:
+    # Handle direct name references like @property or @cached_property
     if isinstance(decorator, ast.Name):
-        return decorator.id == "property"
+        return decorator.id in {"property", "cached_property"}
+
+    # Handle attribute references like @functools.cached_property
     if isinstance(decorator, ast.Attribute) and decorator.attr in {"property", "setter", "cached_property"}:
         if isinstance(decorator.value, ast.Name) and decorator.value.id == "functools":
             return decorator.attr == "cached_property"
         return decorator.attr in {"property", "setter"}
+
+    # Handle decorator calls like @property() or @functools.cached_property()
+    if isinstance(decorator, ast.Call):
+        if isinstance(decorator.func, ast.Name):
+            return decorator.func.id in {"property", "cached_property"}
+        if isinstance(decorator.func, ast.Attribute):
+            if decorator.func.attr in {"property", "setter", "cached_property"}:
+                if isinstance(decorator.func.value, ast.Name) and decorator.func.value.id == "functools":
+                    return decorator.func.attr == "cached_property"
+                return decorator.func.attr in {"property", "setter"}
+
     return False
 
 

src/community_of_python_flake8_plugin/checks/name_length.py

@@ -93,15 +93,12 @@ def validate_name_length(self, identifier: str, ast_node: ast.stmt, parent_class
         if len(identifier) < MIN_NAME_LENGTH:
             # Determine if this is an attribute (inside a class) or variable (at module level)
             is_attribute = parent_class is not None
-            
             self.violations.append(
                 Violation(
                     line_number=ast_node.lineno,
                     column_number=ast_node.col_offset,
                     violation_code=(
-                        ViolationCodes.ATTRIBUTE_NAME_LENGTH
-                        if is_attribute
-                        else ViolationCodes.VARIABLE_NAME_LENGTH
+                        ViolationCodes.ATTRIBUTE_NAME_LENGTH if is_attribute else ViolationCodes.VARIABLE_NAME_LENGTH
                     ),
                 )
             )

src/community_of_python_flake8_plugin/constants.py

@@ -107,6 +107,7 @@
     "measure",
     "ensure",
     "submit",
+    "clear",
 }
 
 SCALAR_ANNOTATIONS: typing.Final = {"int", "str", "float", "bool", "bytes", "complex"}

tests/test_plugin.py

@@ -50,6 +50,7 @@ def test_import_stdlib_validations(input_source: str, expected_output: list[str]
         [item[2].split(" ")[0] for item in CommunityOfPythonFlake8Plugin(ast.parse(input_source)).run()]  # noqa: COP011
     ) == sorted(expected_output)
 
+
 @pytest.mark.skip("disabled")
 @pytest.mark.parametrize(
     ("input_source", "expected_output"),
@@ -161,6 +162,41 @@ def test_type_annotation_validations(input_source: str, expected_output: list[st
             "import pytest\n@pytest.fixture(name='events')\ndef fixture_events() -> list[dict]:\n    return []",
             [],
         ),
+        # No violation: property decorator should exempt function from COP009 (but not COP007 for name length)
+        (
+            "class ExampleClass:\n    @property\n    def calculator(): pass",
+            ["COP012"],
+        ),
+        # No violation: property() decorator call should exempt function from COP009 (but not COP007)
+        (
+            "class ExampleClass:\n    @property()\n    def calculator(): pass",
+            ["COP012"],
+        ),
+        # No violation: cached_property decorator should exempt function from COP009 (but not COP007)
+        (
+            "import functools\nclass ExampleClass:\n    @functools.cached_property\n    def calculator(): pass",
+            ["COP012"],
+        ),
+        # No violation: cached_property() decorator call should exempt function from COP009 (but not COP007)
+        (
+            "import functools\nclass ExampleClass:\n    @functools.cached_property()\n    def calculator(): pass",
+            ["COP012"],
+        ),
+        # No violation: ModelFactory methods should be exempt from COP009
+        (
+            "from polyfactory.factories.pydantic_factory import ModelFactory\nclass MyFactory(ModelFactory):\n    def calculator(self): pass",
+            ["COP012"],
+        ),
+        # No violation: cached_property imported directly should exempt function from COP009 (but triggers COP002 for import style)
+        (
+            "from functools import cached_property\nclass ExampleClass:\n    @cached_property\n    def calculator(self): pass",
+            ["COP002", "COP012"],
+        ),
+        # No violation: cached_property() imported directly should exempt function from COP009 (but triggers COP002)
+        (
+            "from functools import cached_property\nclass ExampleClass:\n    @cached_property()\n    def calculator(self): pass",
+            ["COP002", "COP012"],
+        ),
         # No violation: pytest fixture with name parameter should be exempt from COP009
         (
             "import pytest\n@pytest.fixture(name='events')\ndef fixture_events() -> list[dict]:\n    return []",