Refactor function verb check and move utility functions

Author: vrslev

src/community_of_python_flake8_plugin/checks/function_verb.py

@@ -82,9 +82,6 @@ def validate_function_name(
         ):
             return
 
-        if len(ast_node.name) < 3:  # noqa: PLR2004  # Short names are likely acronyms or special cases
-            return
-
         self.violations.append(
             Violation(
                 line_number=ast_node.lineno,

src/community_of_python_flake8_plugin/checks/module_import_many_names.py

@@ -4,11 +4,25 @@
 from importlib import util as importlib_util
 
 from community_of_python_flake8_plugin import constants
-from community_of_python_flake8_plugin.utils import check_module_has_all_declaration
 from community_of_python_flake8_plugin.violation_codes import ViolationCodes
 from community_of_python_flake8_plugin.violations import Violation
 
 
+def check_module_has_all_declaration(module_node: ast.Module) -> bool:
+    for statement in module_node.body:
+        if isinstance(statement, ast.Assign) and any(
+            isinstance(target, ast.Name) and target.id == "__all__" for target in statement.targets
+        ):
+            return True
+        if (
+            isinstance(statement, ast.AnnAssign)
+            and isinstance(statement.target, ast.Name)
+            and statement.target.id == "__all__"
+        ):
+            return True
+    return False
+
+
 def check_module_path_exists(module_name: str) -> bool:
     try:
         return importlib_util.find_spec(module_name) is not None

src/community_of_python_flake8_plugin/checks/scalar_annotation.py

@@ -3,7 +3,7 @@
 import typing
 
 from community_of_python_flake8_plugin.constants import SCALAR_ANNOTATIONS
-from community_of_python_flake8_plugin.utils import find_parent_class_definition, find_parent_function
+from community_of_python_flake8_plugin.utils import find_parent_class_definition
 from community_of_python_flake8_plugin.violation_codes import ViolationCodes
 from community_of_python_flake8_plugin.violations import Violation
 
@@ -36,9 +36,18 @@ def check_is_scalar_annotation(annotation_node: ast.AST) -> bool:
     return False
 
 
+def find_parent_function(syntax_tree: ast.AST, target_node: ast.AST) -> ast.FunctionDef | ast.AsyncFunctionDef | None:
+    for potential_parent in ast.walk(syntax_tree):
+        if isinstance(potential_parent, (ast.FunctionDef, ast.AsyncFunctionDef)):
+            for child_node in ast.walk(potential_parent):  # noqa: COP007
+                if child_node is target_node:
+                    return potential_parent
+    return None
+
+
 @typing.final
 class ScalarAnnotationCheck(ast.NodeVisitor):
-    def __init__(self, tree: ast.AST) -> None: # noqa: COP004G
+    def __init__(self, tree: ast.AST) -> None:  # noqa: COP004G
         self.violations: list[Violation] = []
         self.syntax_tree: typing.Final[ast.AST] = tree
 

src/community_of_python_flake8_plugin/plugin.py

@@ -32,9 +32,6 @@ def run(self) -> Iterable[tuple[int, int, str, type[object]]]:  # noqa: COP004F
         checks_collection: typing.Final[list[PluginCheckProtocol]] = []
 
         for _, module_name, _ in pkgutil.iter_modules(checks_module.__path__):
-            if module_name == "__init__":
-                continue
-
             module_full_name = f"{checks_module.__name__}.{module_name}"  # noqa: COP007
             imported_module = importlib.import_module(module_full_name)
 

src/community_of_python_flake8_plugin/utils.py

@@ -2,34 +2,10 @@
 import ast
 
 
-def check_module_has_all_declaration(module_node: ast.Module) -> bool:
-    for statement in module_node.body:
-        if isinstance(statement, ast.Assign) and any(
-            isinstance(target, ast.Name) and target.id == "__all__" for target in statement.targets
-        ):
-            return True
-        if (
-            isinstance(statement, ast.AnnAssign)
-            and isinstance(statement.target, ast.Name)
-            and statement.target.id == "__all__"
-        ):
-            return True
-    return False
-
-
 def find_parent_class_definition(syntax_tree: ast.AST, target_node: ast.AST) -> ast.ClassDef | None:
     for potential_parent in ast.walk(syntax_tree):
         if isinstance(potential_parent, ast.ClassDef):
             for child_node in ast.walk(potential_parent):  # noqa: COP007
                 if child_node is target_node:
                     return potential_parent
     return None
-
-
-def find_parent_function(syntax_tree: ast.AST, target_node: ast.AST) -> ast.FunctionDef | ast.AsyncFunctionDef | None:
-    for potential_parent in ast.walk(syntax_tree):
-        if isinstance(potential_parent, (ast.FunctionDef, ast.AsyncFunctionDef)):
-            for child_node in ast.walk(potential_parent):  # noqa: COP007
-                if child_node is target_node:
-                    return potential_parent
-    return None