Rename comprehension check to for-loop check and update related code

- Rename `comprehension_one_prefix.py` to `for_loop_one_prefix.py`
- Update class name from `COP015ComprehensionOnePrefixCheck` to
  `COP015ForLoopOnePrefixCheck`
- Change violation code description from "Comprehension variables" to
  "For-loop variables"
- Add tests for regular for-loop cases
- Rename loop variables in several files for clarity
- Remove unused import `MIN_NAME_LENGTH`

Author: vrslev

src/community_of_python_flake8_plugin/checks/dataclass_config.py

@@ -25,9 +25,9 @@ def has_required_dataclass_params(decorator: ast.expr) -> bool:
         return False
 
     keywords: typing.Final = {
-        keyword_item.arg: keyword_item.value
-        for keyword_item in decorator.keywords
-        if isinstance(keyword_item.value, ast.Constant)
+        one_keyword_item.arg: one_keyword_item.value
+        for one_keyword_item in decorator.keywords
+        if isinstance(one_keyword_item.value, ast.Constant)
     }
     kw_only_param: typing.Final = keywords.get("kw_only")
     slots_param: typing.Final = keywords.get("slots")
@@ -47,20 +47,20 @@ def has_required_dataclass_params(decorator: ast.expr) -> bool:
 
 def is_pydantic_model(class_node: ast.ClassDef) -> bool:
     """Check if class inherits from Pydantic BaseModel or RootModel."""
-    for base_class in class_node.bases:
-        if isinstance(base_class, ast.Name) and base_class.id in {"BaseModel", "RootModel"}:
+    for one_base_class in class_node.bases:
+        if isinstance(one_base_class, ast.Name) and one_base_class.id in {"BaseModel", "RootModel"}:
             return True
-        if isinstance(base_class, ast.Attribute) and base_class.attr in {"BaseModel", "RootModel"}:
+        if isinstance(one_base_class, ast.Attribute) and one_base_class.attr in {"BaseModel", "RootModel"}:
             return True
     return False
 
 
 def is_model_factory(class_node: ast.ClassDef) -> bool:
     """Check if class inherits from ModelFactory."""
-    for base_class in class_node.bases:
-        if isinstance(base_class, ast.Name) and base_class.id in {"ModelFactory", "SQLAlchemyFactory"}:
+    for one_base_class in class_node.bases:
+        if isinstance(one_base_class, ast.Name) and one_base_class.id in {"ModelFactory", "SQLAlchemyFactory"}:
             return True
-        if isinstance(base_class, ast.Attribute) and base_class.attr in {"ModelFactory", "SQLAlchemyFactory"}:
+        if isinstance(one_base_class, ast.Attribute) and one_base_class.attr in {"ModelFactory", "SQLAlchemyFactory"}:
             return True
     return False
 
@@ -82,9 +82,9 @@ def visit_ClassDef(self, ast_node: ast.ClassDef) -> None:
             return
 
         # Check for dataclass decorator
-        for decorator in ast_node.decorator_list:
-            if is_dataclass_decorator(decorator):
-                if not has_required_dataclass_params(decorator):
+        for one_decorator in ast_node.decorator_list:
+            if is_dataclass_decorator(one_decorator):
+                if not has_required_dataclass_params(one_decorator):
                     self.violations.append(
                         Violation(
                             line_number=ast_node.lineno,
@@ -98,9 +98,9 @@ def visit_ClassDef(self, ast_node: ast.ClassDef) -> None:
 
     def _inherits_from_exception(self, ast_node: ast.ClassDef) -> bool:
         """Check if class inherits from Exception or its subclasses."""
-        for base in ast_node.bases:
-            if isinstance(base, ast.Name) and ("Error" in base.id or "Exception" in base.id):
+        for one_base in ast_node.bases:
+            if isinstance(one_base, ast.Name) and ("Error" in one_base.id or "Exception" in one_base.id):
                 return True
-            if isinstance(base, ast.Attribute) and ("Error" in base.attr or "Exception" in base.attr):
+            if isinstance(one_base, ast.Attribute) and ("Error" in one_base.attr or "Exception" in one_base.attr):
                 return True
         return False

src/community_of_python_flake8_plugin/checks/disabled/module_import_many_names.py

@@ -17,16 +17,16 @@
 
 
 def check_module_has_all_declaration(module_node: ast.Module) -> bool:
-    for statement in module_node.body:
-        if isinstance(statement, ast.Assign) and any(
-            isinstance(target_element, ast.Name) and target_element.id == "__all__"
-            for target_element in statement.targets
+    for one_statement in module_node.body:
+        if isinstance(one_statement, ast.Assign) and any(
+            isinstance(one_target_element, ast.Name) and one_target_element.id == "__all__"
+            for one_target_element in one_statement.targets
         ):
             return True
         if (
-            isinstance(statement, ast.AnnAssign)
-            and isinstance(statement.target, ast.Name)
-            and statement.target.id == "__all__"
+            isinstance(one_statement, ast.AnnAssign)
+            and isinstance(one_statement.target, ast.Name)
+            and one_statement.target.id == "__all__"
         ):
             return True
     return False
@@ -77,9 +77,9 @@ def validate_import_size(self, ast_node: ast.ImportFrom) -> None:
             return
 
         if not any(
-            check_module_path_exists(f"{module_name}.{alias_element.name}")
-            for alias_element in ast_node.names
-            if isinstance(alias_element, ast.alias) and module_name is not None
+            check_module_path_exists(f"{module_name}.{one_alias_element.name}")
+            for one_alias_element in ast_node.names
+            if isinstance(one_alias_element, ast.alias) and module_name is not None
         ):
             self.violations.append(
                 Violation(

src/community_of_python_flake8_plugin/checks/final_class.py

@@ -7,8 +7,8 @@
 
 
 def contains_final_decorator(class_node: ast.ClassDef) -> bool:
-    for decorator in class_node.decorator_list:
-        target_name = decorator.func if isinstance(decorator, ast.Call) else decorator
+    for one_decorator in class_node.decorator_list:
+        target_name = one_decorator.func if isinstance(one_decorator, ast.Call) else one_decorator
         if isinstance(target_name, ast.Name) and target_name.id == "final":
             return True
         if isinstance(target_name, ast.Attribute) and target_name.attr == "final":
@@ -18,12 +18,12 @@ def contains_final_decorator(class_node: ast.ClassDef) -> bool:
 
 def is_protocol_class(class_node: ast.ClassDef) -> bool:
     """Check if the class directly inherits from typing.Protocol."""
-    for base in class_node.bases:
+    for one_base in class_node.bases:
         # Check for direct Protocol reference: class MyClass(Protocol):
-        if isinstance(base, ast.Name) and base.id == "Protocol":
+        if isinstance(one_base, ast.Name) and one_base.id == "Protocol":
             return True
         # Check for attributed Protocol reference: class MyClass(typing.Protocol):
-        if isinstance(base, ast.Attribute) and base.attr == "Protocol":
+        if isinstance(one_base, ast.Attribute) and one_base.attr == "Protocol":
             return True
     return False
 

…lugin/checks/comprehension_one_prefix.py …ke8_plugin/checks/for_loop_one_prefix.pysrc/community_of_python_flake8_plugin/checks/comprehension_one_prefix.py renamed to src/community_of_python_flake8_plugin/checks/for_loop_one_prefix.py src/community_of_python_flake8_plugin/checks/comprehension_one_prefix.py renamed to src/community_of_python_flake8_plugin/checks/for_loop_one_prefix.py

@@ -2,7 +2,6 @@
 import ast
 import typing
 
-from community_of_python_flake8_plugin.constants import MIN_NAME_LENGTH
 from community_of_python_flake8_plugin.violation_codes import ViolationCodes
 from community_of_python_flake8_plugin.violations import Violation
 
@@ -14,8 +13,8 @@ def _is_ignored_target(target_node: ast.expr) -> bool:
 
 
 @typing.final
-class COP015ComprehensionOnePrefixCheck(ast.NodeVisitor):
-    def __init__(self, syntax_tree: ast.AST) -> None:  # noqa: ARG002
+class COP015ForLoopOnePrefixCheck(ast.NodeVisitor):
+    def __init__(self, syntax_tree: ast.AST) -> None:
         self.violations: list[Violation] = []
         self.syntax_tree: typing.Final[ast.AST] = syntax_tree
 
@@ -97,7 +96,7 @@ def _validate_comprehension_target(self, target_node: ast.expr) -> None:
                     Violation(
                         line_number=target_node.lineno,
                         column_number=target_node.col_offset,
-                        violation_code=ViolationCodes.COMPREHENSION_VARIABLE_PREFIX,
+                        violation_code=ViolationCodes.FOR_LOOP_VARIABLE_PREFIX,
                     )
                 )
         # For tuples (unpacking), validate each element
@@ -108,7 +107,7 @@ def _validate_comprehension_target(self, target_node: ast.expr) -> None:
                         Violation(
                             line_number=one_element.lineno,
                             column_number=one_element.col_offset,
-                            violation_code=ViolationCodes.COMPREHENSION_VARIABLE_PREFIX,
+                            violation_code=ViolationCodes.FOR_LOOP_VARIABLE_PREFIX,
                         )
                     )
 
@@ -117,6 +116,6 @@ def _has_valid_one_prefix(self, identifier: str) -> bool:
         # Allow underscore variables
         if identifier == "_":
             return True
-            
+
         # Check for one_ prefix
         return identifier.startswith("one_")

src/community_of_python_flake8_plugin/violation_codes.py

@@ -48,7 +48,7 @@ class ViolationCodes:
         code="COP014", description="Use dataclasses with kw_only=True, slots=True, frozen=True"
     )
 
-    # Comprehension variable prefix violations
-    COMPREHENSION_VARIABLE_PREFIX = ViolationCodeItem(
-        code="COP015", description="Comprehension variables must be prefixed with 'one_'"
+    # For-loop variable prefix violations
+    FOR_LOOP_VARIABLE_PREFIX = ViolationCodeItem(
+        code="COP015", description="For-loop variables must be prefixed with 'one_'"
     )

tests/test_plugin.py

@@ -517,6 +517,16 @@ def test_dataclass_validations(input_source: str, expected_output: list[str]) ->
         ("result_long_name = (v for v in some_list)", ["COP005", "COP015"]),
         # COP005: Generator expression with one_ prefix (vars still too short for general rule)
         ("result_long_name = (one_v for one_v in some_list)", ["COP005"]),
+        # COP015: Regular for-loop without one_ prefix should be flagged
+        ("for v in some_list: pass", ["COP015"]),
+        # No violation: Regular for-loop with one_ prefix
+        ("for one_v in some_list: pass", []),
+        # No violation: Regular for-loop with underscore (ignored)
+        ("for _ in some_list: pass", []),
+        # No violation: Regular for-loop with tuple unpacking (ignored)
+        ("for x, y in pairs: pass", []),
+        # No violation: Regular for-loop with one_ prefix
+        ("for one_x in some_list: pass", []),
     ],
 )
 def test_module_vs_class_level_assignments(input_source: str, expected_output: list[str]) -> None: