ADD support for private verbs and update tests

- Allow function names starting with underscore to be considered verbs
- Add "fill" to the list of recognized verb prefixes
- Update test cases to reflect new behavior for private verb names
- Fix false positive for private methods with verb-like names

Author: vrslev

src/community_of_python_flake8_plugin/checks/function_verb.py

@@ -11,14 +11,13 @@
 def check_is_ignored_name(identifier: str) -> bool:
     if identifier == "main":
         return True
-    if identifier.startswith("__") and identifier.endswith("__"):
-        return True
-    return bool(identifier.startswith("_"))
+    return bool(identifier.startswith("__") and identifier.endswith("__"))
 
 
 def check_is_verb_name(identifier: str) -> bool:
     return any(
-        identifier == one_verb_name or identifier.startswith(f"{one_verb_name}_") for one_verb_name in VERB_PREFIXES
+        identifier == one_verb_name or identifier.startswith((f"{one_verb_name}_", f"_{one_verb_name}"))
+        for one_verb_name in VERB_PREFIXES
     )
 
 

src/community_of_python_flake8_plugin/constants.py

@@ -110,6 +110,7 @@
     "clear",
     "undo",
     "cache",
+    "fill",
 }
 
 SCALAR_ANNOTATIONS: typing.Final = {"int", "str", "float", "bool", "bytes", "complex"}

tests/test_plugin.py

@@ -150,12 +150,14 @@ def test_type_annotation_validations(input_source: str, expected_output: list[st
         ("class ExampleClass:\n    _ = 1", ["COP012"]),
         # COP007: Function name must be a verb
         ("def total_value() -> int:\n    return 1", ["COP009"]),
+        # COP007: Function name must be a verb
+        ("def _total_value() -> int:\n    return 1", ["COP009"]),
         # No violation: get_ prefix is allowed for sync functions
         ("def get_user_data() -> str:\n    return 'value'", []),
         # COP010: Avoid get_ prefix in async function names
         ("async def get_user_data() -> str:\n    return 'value'", ["COP010"]),
         # COP009: Function name must be a verb (even with mutable params)
-        ("def fill_values(values: list[int]) -> None:\n    values[0] = 1", ["COP009"]),
+        ("def _fill_values(values: list[int]) -> None:\n    values[0] = 1", []),
         # No violation: pytest fixture annotation is whitelisted
         (
             "import pytest\n@pytest.fixture\ndef some_fixture(arg: pytest.fixture): pass",